Skip to content

sunrpc: Sunrpc cache cleanups and upcall rework

Greg Banks linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14sunrpc: Use consistent naming for variables of type struct cache_detail*.net/sunrpc/cache.c+62 -620 replies
2/14sunrpc: Use consistent naming for variables of type struct cache_head*net/sunrpc/cache.c+50 -500 replies
3/14sunrpc: Use consistent naming for variables of type struct cache_request*.net/sunrpc/cache.c+19 -190 replies
4/14sunrpc: Minor indentation cleanup in cache.cnet/sunrpc/cache.c+2 -20 replies
5/14sunrpc: Rename queue_loose() to cache_remove_queued().net/sunrpc/cache.c+4 -40 replies
6/14sunrpc: Gather forward declarations of static functions in cache.c.net/sunrpc/cache.c+3 -30 replies
7/14sunrpc: Make the global queue_lock per-cache-detail.include/linux/sunrpc/cache.h net/sunrpc/cache.c+26 -240 replies
8/14sunrpc: Make the global queue_wait per-cache-detail.include/linux/sunrpc/cache.h net/sunrpc/cache.c+5 -40 replies
9/14sunrpc: Remove the global lock queue_io_mutex.net/sunrpc/cache.c+15 -190 replies
10/14sunrpc: Reorganise the queuing of cache upcalls.include/linux/sunrpc/cache.h net/sunrpc/cache.c+112 -15510 replies
11/14sunrpc: Allocate cache_requests in a single allocation.net/sunrpc/cache.c+8 -200 replies
12/14sunrpc: Centralise memory management of cache_requests.net/sunrpc/cache.c+35 -110 replies
13/14sunrpc: Move struct cache_request to linux/sunrpc/cache.hinclude/linux/sunrpc/cache.h net/sunrpc/cache.c+35 -350 replies
14/14sunrpc: Improve the usefulness of debug printks in the sunrpc cache code.net/sunrpc/cache.c+97 -150 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 00/14] sunrpc: Sunrpc cache cleanups and upcall rework

G'day,

These patches are a snapshot of in-progress work to fix problems with the sunrpc upcall mechanism which are triggered under load when using multi-threaded rpc.mountd. These are currently a hot issue with one of SGI's customers (SGI PV988959).

The early patches in the series are cleanups with zero logic changes.

The patches have been lightly tested, by mounting and running the cthon04 tests. They have not been shipped or used in the field.

Signature · 3 lines
Greg Banks, P.Engineer, SGI Australian Software Group.
the brightly coloured sporks of revolution.
I don't speak for SGI.