Skip to content

RFC mac80211: ps-poll implementation

Kalle Valo linux-wireless 2 versions New

Get series with b4
b4 am 20090111185310.6137.66672.stgit@tikku

Versions newest first · linked by author and title

  1. v2 RFC Latest2 patches 0 repliesNew
  2. v1 RFC2 patches 4 repliesSuperseded

Changes in v2 from the cover letter

o RX_CONTINUE after sending ps-poll frame in ieee80211_rx_h_check_more_data()
o remove debug printk

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mac80211: remove multicast check from check_tim()net/mac80211/mlme.c+4 -70 replies
2/2mac80211: use ps-poll to request frames in power save modenet/mac80211/ieee80211_i.h net/mac80211/mlme.c net/mac80211/rx.c+74 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC PATCH v2 0/2] mac80211: ps-poll implementation

Here's my suggestion for how to implement ps-poll in mac80211. Also this fixes power save again for p54/stlc45xx, but most probably breaks ath9k. I would like to hear opinions from others, especially from Atheros. How does ath9k cope with the ps-poll method? Also I highly recommend to get hardware waking up for multicast frames, it would be a lot easier and reliable that way.

Open question is that should power save be disabled whenever mac80211 is ps-polling the frames. For example, p54/stlc45xx does not require to disable power save in that case, it just stays awake long enough to receive the data frame from the AP. So I did not disable power save mode in this case, but I would like to hear comments what other hardware needs.

v2:

o RX_CONTINUE after sending ps-poll frame in ieee80211_rx_h_check_more_data()
o remove debug printk

---

Kalle Valo (2):
mac80211: use ps-poll to request frames in power save mode
mac80211: remove multicast check from check_tim()

 net/mac80211/ieee80211_i.h |    3 +++
 net/mac80211/mlme.c        |   51 +++++++++++++++++++++++++++++++++++---------
 net/mac80211/rx.c          |   34 +++++++++++++++++++++++++++++
 3 files changed, 78 insertions(+), 10 deletions(-)