Hibernation/poweroff quirks (was: Re: [git patches] libata hibernation fixes)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 13 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | Hibernation: Introduce system_entering_hibernationinclude/ kernel/ | +12 | 6 replies | |
| 2/6 | DMI: Introduce dmi_first_match to make the interface more flexibledrivers/ include/ | +55 | 2 replies | |
| 3/6 | SATA: Blacklisting of systems that spin off disks during ACPI power offdrivers/ include/ | +19 | 1 reply | |
| 4/6 | SATA AHCI: Blacklist system that spins off disks during ACPI power offdrivers/ | +32 | 1 reply | |
| 5/6 | SATA Sil: Blacklist system that spins off disks during ACPI power offdrivers/ | +35 | 1 reply | |
| 6/6 | SATA PIIX: Blacklist system that spins off disks during ACPI power offdrivers/ | +34 | 2 replies |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by.
| Patch | Frans Pop | Maciej Rutecki |
|---|---|---|
| 1/6 | T-b | |
| 2/6 | T-b | |
| 3/6 | T-b | |
| 4/6 | T-b | |
| 5/6 | T-b | |
| 6/6 | T-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] Hibernation/poweroff quirks (was: Re: [git patches] libata hibernation fixes)
Quoted 15 lines · Jeff Garzik
Quoted 14 lines · Rafael J. Wysocki
Quoted 12 lines · Frans Pop
Quoted 2 lines · Rafael J. Wysocki
There is a name conflict with a change applied after this patchset had been created. The appended patch fixes it for me.
[...]
Review const struct dmi_system_id *dmi_first_match(const struct dmi_system_id *list) · line 487
Quoted 7 lines
(quoted diff) +1
-1@@ -483,7 +483,7 @@ const struct dmi_system_id *dmi_first_match(const struct dmi_system_id *list) const struct dmi_system_id *d; for (d = list; d->ident; d++) - if (dmi_match(d)) + if (dmi_matches(d)) return d;I get two warnings when compiling your patch with this correction on top:
Quoted 6 lines
Quoted 3 lines
Hm, there were more patches than one, so I'm not sure. When I apply all of them, I don't see these error, but perhaps I should resend the entire series. Will do tomorrow.
That would be useful... I was planning to regenerate the series, but this would save time.
The rebased series follows.
Thanks,
Rafael