Skip to content

Hibernation/poweroff quirks (was: Re: [git patches] libata hibernation fixes)

Rafael J. Wysocki linux-ide lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6Hibernation: Introduce system_entering_hibernationinclude/linux/suspend.h kernel/power/disk.c+12 -06 replies
2/6DMI: Introduce dmi_first_match to make the interface more flexibledrivers/firmware/dmi_scan.c include/linux/dmi.h+55 -182 replies
3/6SATA: Blacklisting of systems that spin off disks during ACPI power offdrivers/ata/libata-scsi.c include/linux/libata.h+19 -31 reply
4/6SATA AHCI: Blacklist system that spins off disks during ACPI power offdrivers/ata/ahci.c+32 -01 reply
5/6SATA Sil: Blacklist system that spins off disks during ACPI power offdrivers/ata/sata_sil.c+35 -11 reply
6/6SATA PIIX: Blacklist system that spins off disks during ACPI power offdrivers/ata/ata_piix.c+34 -02 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchFrans PopMaciej Rutecki
1/6T-b
2/6T-b
3/6T-b
4/6T-b
5/6T-b
6/6T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] Hibernation/poweroff quirks (was: Re: [git patches] libata hibernation fixes)
Quoted 15 lines · Jeff Garzik
Quoted 14 lines · Rafael J. Wysocki
Quoted 12 lines · Frans Pop
Quoted 2 lines · Rafael J. Wysocki

There is a name conflict with a change applied after this patchset had been created. The appended patch fixes it for me.

[...]

Review const struct dmi_system_id *dmi_first_match(const struct dmi_system_id *list) · line 487

Quoted 7 lines
(quoted diff) +1 -1
@@ -483,7 +483,7 @@ const struct dmi_system_id *dmi_first_match(const struct dmi_system_id *list)
        const struct dmi_system_id *d; 
 
        for (d = list; d->ident; d++)
-               if (dmi_match(d))
+               if (dmi_matches(d))
                        return d;

I get two warnings when compiling your patch with this correction on top:

Quoted 6 lines
Quoted 3 lines

Hm, there were more patches than one, so I'm not sure. When I apply all of them, I don't see these error, but perhaps I should resend the entire series. Will do tomorrow.

That would be useful... I was planning to regenerate the series, but this would save time.

The rebased series follows.

Thanks,
Rafael