PCI core learns hotplug
Status from this message: Applied this series, thanks everyone!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest13 patches 17 repliesApplied
- v412 patches 30 repliesSuperseded
- v311 patches 15 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 RFC | 12 patches | 0 replies | Superseded | |
| v1 RFC | 10 patches | 5 replies | Applied |
Changes in v5 from the cover letter
- acquire pci_bus_sem when walking device list in pci_rescan_bus
- keep CONFIG_HOTPLUG (instead of CONFIG_HOTPLUG_PCI)
- comment why we need device_schedule_callback()
- remove CAP_SYS_ADMIN check
- do not remove primary bus in remove_callback()
- do not enable bridges multiple times
- checkpatch cleanups
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | PCI: pci_is_root_bus helperinclude/ | +9 | 1 reply | |
| 2/13 | PCI: don't scan existing devicesdrivers/ | +6 | 0 replies | |
| 3/13 | PCI: pci_scan_slot() returns newly found devicesdrivers/ | +16 | 0 replies | |
| 4/13 | PCI: always scan child busesdrivers/ | +20 | 0 replies | |
| 5/13 | PCI: do not initialize bridges more than oncedrivers/ | +3 | 0 replies | |
| 6/13 | PCI: do not enable bridges more than oncedrivers/ | +4 | 0 replies | |
| 7/13 | PCI: Introduce pci_rescan_bus()drivers/ drivers/ include/ | +38 | 0 replies | |
| 8/13 | PCI: Introduce /sys/bus/pci/rescanDocumentation/ drivers/ drivers/ +2 more | +44 | 0 replies | |
| 9/13 | PCI: Introduce /sys/bus/pci/devices/.../removeDocumentation/ Documentation/ drivers/ | +54 | 15 replies | |
| 10/13 | PCI: Introduce /sys/bus/pci/devices/.../rescanDocumentation/ drivers/ | +29 | 0 replies | |
| 11/13 | PCI Hotplug: restore fakephp interface with complete reimplementationdrivers/ drivers/ drivers/ | +163 | 0 replies | |
| 12/13 | PCI Hotplug: rename legacy_fakephp to fakephpdrivers/ drivers/ drivers/ | +163 | 0 replies | |
| 13/13 | PCI Hotplug: schedule fakephp for feature removalDocumentation/ | +33 | 1 reply |
Reviews trailers per patch
2 of 13 patches have a Reviewed-by or Acked-by.
| Patch | Alex Chiang | James Cameron |
|---|---|---|
| 1/13 | ||
| 2/13 | ||
| 3/13 | R-b | |
| 4/13 | ||
| 5/13 | ||
| 6/13 | ||
| 7/13 | ||
| 8/13 | ||
| 9/13 | ||
| 10/13 | ||
| 11/13 | R-b | |
| 12/13 | ||
| 13/13 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 00/13] PCI core learns hotplug
Here is v5 of this series that addresses the review comments from v4.
I've pushed out a new test tree that contains the updated series for testing. The tree consists of:
Linus's v2.6.28
+ Jesse's linux-next queue (as of 19 March 2009)
+ the 13 patches in this series
It does not contain the sysfs callback patch that is required for interface torture tests. That can be had here:
http://thread.gmane.org/gmane.linux.kernel/806648
You can pull my tree here:
git://git.kernel.org/pub/scm/linux/kernel/git/achiang/pci-hotplug.git test-20090319
This is also a nice chance to test the shiny new patchwork instance that we have running on kernel.org that we hope to use for linux-pci in the future:
http://patchwork.kernel.org/project/linux-pci/list/
I still haven't figured out the locking issue that Kenji-san pointed out from last time, because I haven't been able to reproduce it.
Any further testing/review is welcomed and appreciated.
Thanks!
/ac
v4 -> v5:
- acquire pci_bus_sem when walking device list in pci_rescan_bus
- keep CONFIG_HOTPLUG (instead of CONFIG_HOTPLUG_PCI)
- comment why we need device_schedule_callback()
- remove CAP_SYS_ADMIN check
- do not remove primary bus in remove_callback()
- do not enable bridges multiple times
- checkpatch cleanups
v3 -> v4:
- protect sysfs interfaces with mutex
- undo changes in pci_do_scan_bus
- introduce pci_rescan_bus instead
- do not initialize bridges more than once
v2 -> v3:
- properly remove device with internal bridge
- added Kenji Kaneshige's pci_is_root_bus() interface
- dropped whitespace cleanups for another time
v1 -> v2:
- incorporated lots of Trent Piepho's work
- beefed up pci_do_scan_bus as heavy lifter for rescanning
- small bugfixes folded into earlier patches to get everything working
---
Alex Chiang (9):
PCI Hotplug: schedule fakephp for feature removal PCI Hotplug: rename legacy_fakephp to fakephp
PCI: Introduce /sys/bus/pci/devices/.../rescan
PCI: Introduce /sys/bus/pci/devices/.../remove
PCI: Introduce /sys/bus/pci/rescan
PCI: Introduce pci_rescan_bus()
PCI: do not enable bridges more than once
PCI: do not initialize bridges more than once
PCI: always scan child buses
Kenji Kaneshige (1):
PCI: pci_is_root_bus helper
Trent Piepho (3):
PCI Hotplug: restore fakephp interface with complete reimplementation
PCI: pci_scan_slot() returns newly found devices
PCI: don't scan existing devices
Documentation/ABI/testing/sysfs-bus-pci | 27 ++ Documentation/feature-removal-schedule.txt | 33 ++ Documentation/filesystems/sysfs-pci.txt | 10 + drivers/pci/bus.c | 6 drivers/pci/hotplug/fakephp.c | 443 +++++++--------------------- drivers/pci/pci-driver.c | 1 drivers/pci/pci-sysfs.c | 81 +++++ drivers/pci/pci.h | 6 drivers/pci/probe.c | 112 +++++-- drivers/pci/setup-bus.c | 3 include/linux/pci.h | 12 + 11 files changed, 356 insertions(+), 378 deletions(-)