ACPICA: Fix truncation message calculation
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ACPICA: Fix table entry truncation calculationdrivers/ | +3 | 0 replies | |
| 2/2 | ACPICA: 80 column adherence (no functional change)drivers/ | +25 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] ACPICA: Fix truncation message calculation
Len:
The following two item patch series fixes a calculation in ./drivers/acpi/tables/tbutils.c::acpi_tb_parse_root_table() that determines how many ACPI table entries will be truncated when the number of RSDT/XSDT entries is greater than the statically allocated 'initial_tables[]' array.
As currently implemented, the calculation will always yield a value of 0. The following output shows the issue (Note the line with
"...: Truncating ..." which incorrectly indicates 0):
ACPI: RSDP 32A82014, 0024 (r2 HP )
ACPI: XSDT 32A82580, 0494 (r1 HP XXXXXX 0 1000013)
ACPI Error (tbinstal-0207): Resize of Root Table Array is not allowed [20070126] ACPI Warning (tbutils-0519): Truncating 0 table entries! [20070126]
ACPI: FACP 32A6C000, 00F4 (r3 HP XXXXXX 0 HP 0) ACPI: DSDT 32A52000, 8E83 (r2 HP XXXXXX 8 INTL 20061109)
...
With the patch applied, the output correctly shows the number of (missing) truncated entries:
ACPI: RSDP 32A82014, 0024 (r2 HP )
ACPI: XSDT 32A82580, 0494 (r1 HP XXXXXX 0 1000013)
ACPI Error (tbinstal-0207): Resize of Root Table Array is not allowed [20070126] ACPI Warning (tbutils-0519): Truncating 5 table entries! [20070126]
ACPI: FACP 32A6C000, 00F4 (r3 HP XXXXXX 0 HP 0) ACPI: DSDT 32A52000, 8E83 (r2 HP XXXXXX 8 INTL 20061109)
...
[PATCH 1/2] fixes the truncation message related calculation.
[PATCH 2/2] is non-functional white space fixes - 80 column adherence - for the same file.
The underlying code affected is common to both x86 and ia64. I have tested the patch on an ia64 platform.
All comments welcome.
Myron
---
Myron Stowe (2):
ACPICA: 80 column adherence (no functional change)
ACPICA: Fix table entry truncation calculation
drivers/acpi/acpica/tbutils.c | 43 +++++++++++++++++++++++++++-------------- 1 files changed, 28 insertions(+), 15 deletions(-)