Skip to content

libfdt: Cleanups to iteration functions [resend]

David Gibson linux-devicetree 1 version Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2libfdt: Rework fdt_next_node()libfdt/fdt.c libfdt/fdt_ro.c libfdt/fdt_wip.c+16 -471 reply
2/2libfdt: Rework/cleanup fdt_next_tag()libfdt/fdt.c libfdt/fdt_ro.c libfdt/fdt_rw.c +2 more+44 -471 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [0/2] libfdt: Cleanups to iteration functions [resend]

Yet more backlog clearing.

These two patches make some cleanups to the fdt_next_node() and fdt_next_tag() functions that I've been meaning to do for a while.

These patches do introduce minor semantic changes, and those are exported functions. I think they're still reasonable changes, because the behavioural changes are in corner cases which previously had somewhat fuzzily defined semantics anyway. I would be very doubtful that anyone was relying on the altered behaviour; if I'm wrong about that these patches could need some rethinking.

These cleanups make it easier to implement property iteration, which I have a draft patch for in the works. I'm not posting that with this series, because I'm having second thoughts about the details of the interface, and I need to write some testcases. I'll try to post that as an RFC / work-in-progress shortly.

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson