Skip to content

Open-FCoE Updates

Robert Love linux-scsi 1 version In review

Get series with b4
b4 am 20090206185548.26188.51580.stgit@fritz

Versions newest first

  1. v1 Latest17 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17libfc: fixed a read IO data integrity issue when a IO data frame lostdrivers/scsi/libfc/fc_fcp.c+3 -30 replies
2/17fcoe: exch mgr is freed while lport still retrying sequencesdrivers/scsi/libfc/fc_lport.c+2 -00 replies
3/17libfc: Don't violate transport template for rogue port creationdrivers/scsi/libfc/fc_disc.c drivers/scsi/libfc/fc_lport.c drivers/scsi/libfc/fc_rport.c +1 more+13 -50 replies
4/17libfc: correct RPORT_TO_PRIV usagedrivers/scsi/libfc/fc_disc.c+2 -20 replies
5/17libfc: rename rp to rdata in fc_disc_new_target()drivers/scsi/libfc/fc_disc.c+4 -40 replies
6/17libfc: check for err when recv and state is incorrectdrivers/scsi/libfc/fc_lport.c drivers/scsi/libfc/fc_rport.c+40 -400 replies
7/17fcoe: runtime debugging with debug_logging module parameterdrivers/scsi/fcoe/fcoe.h drivers/scsi/fcoe/fcoe_sw.c drivers/scsi/fcoe/libfcoe.c+63 -320 replies
8/17fcoe: Logging review changesdrivers/scsi/fcoe/fc_transport_fcoe.c drivers/scsi/fcoe/fcoe_sw.c drivers/scsi/fcoe/libfcoe.c+61 -650 replies
9/17libfc: runtime debugging with debug_logging module parameterdrivers/scsi/libfc/fc_disc.c drivers/scsi/libfc/fc_exch.c drivers/scsi/libfc/fc_fcp.c +3 more+43 -460 replies
10/17libfc: Logging review changesdrivers/scsi/libfc/fc_disc.c drivers/scsi/libfc/fc_exch.c drivers/scsi/libfc/fc_fcp.c +4 more+236 -2470 replies
11/17libfc: Cleanup libfc_function_template commentsinclude/scsi/libfc.h+66 -410 replies
12/17libfc, fcoe: Fix kerneldoc commentsdrivers/scsi/fcoe/fc_transport_fcoe.c drivers/scsi/fcoe/fcoe_sw.c drivers/scsi/fcoe/libfcoe.c +5 more+252 -2570 replies
13/17libfc, fcoe: Cleanup function formatting and minor typosdrivers/scsi/fcoe/fc_transport_fcoe.c drivers/scsi/fcoe/libfcoe.c drivers/scsi/libfc/fc_exch.c +1 more+20 -200 replies
14/17libfc, fcoe: Remove unnecessary cast by removing inline wrapperdrivers/scsi/fcoe/fcoe_sw.c drivers/scsi/fcoe/libfcoe.c include/scsi/libfcoe.h+8 -140 replies
15/17fcoe: Use setup_timer() and mod_timer()drivers/scsi/fcoe/libfcoe.c+3 -50 replies
16/17fcoe: Correct fcoe_transports initialization vs. registrationdrivers/scsi/fcoe/fc_transport_fcoe.c drivers/scsi/fcoe/fcoe_sw.c+5 -30 replies
17/17fcoe: fix kfree(skb)drivers/scsi/fcoe/libfcoe.c+1 -10 replies

Reviews trailers per patch

None of the 17 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMike Christie
SeriesR-b
1/17
2/17
3/17
4/17
5/17
6/17
7/17
8/17
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/17] Open-FCoE Updates

The following series implements bug fixes, adds a module param for runtime debug logging and cleans up some coding style issues. The top patch is a patch that was posted to linux-scsi on 01/04, but doesn't seem to have made it in yet.

This patch set is based on Linus' tree + the Open-FCoE patches submitted to linux-scsi on 01/21.

---

Robert Love (14):
fcoe: Correct fcoe_transports initialization vs. registration
fcoe: Use setup_timer() and mod_timer()
libfc, fcoe: Remove unnecessary cast by removing inline wrapper libfc, fcoe: Cleanup function formatting and minor typos libfc, fcoe: Fix kerneldoc comments
libfc: Cleanup libfc_function_template comments
libfc: Logging review changes
libfc: runtime debugging with debug_logging module parameter
fcoe: Logging review changes
fcoe: runtime debugging with debug_logging module parameter
libfc: check for err when recv and state is incorrect
libfc: rename rp to rdata in fc_disc_new_target()
libfc: correct RPORT_TO_PRIV usage
libfc: Don't violate transport template for rogue port creation

Roel Kluin (1):
[SCSI] fcoe: fix kfree(skb)

Steve Ma (1):
fcoe: exch mgr is freed while lport still retrying sequences

Vasu Dev (1):
libfc: fixed a read IO data integrity issue when a IO data frame lost

 drivers/scsi/fcoe/fc_transport_fcoe.c |  174 ++++++++++-----------
 drivers/scsi/fcoe/fcoe.h              |   31 ++++
 drivers/scsi/fcoe/fcoe_sw.c           |   70 ++++----
 drivers/scsi/fcoe/libfcoe.c           |  267 ++++++++++++++++----------------
 drivers/scsi/libfc/fc_disc.c          |  154 +++++++++---------
 drivers/scsi/libfc/fc_exch.c          |   62 +++----
 drivers/scsi/libfc/fc_fcp.c           |  139 ++++++++---------
 drivers/scsi/libfc/fc_lport.c         |  278 ++++++++++++++++-----------------
 drivers/scsi/libfc/fc_rport.c         |  197 +++++++++++------------
 include/scsi/fc_encode.h              |    2 
 include/scsi/libfc.h                  |  167 +++++++++++++-------
 include/scsi/libfcoe.h                |    8 -
 12 files changed, 793 insertions(+), 756 deletions(-)
 create mode 100644 drivers/scsi/fcoe/fcoe.h
Signature · 1 line
//Rob