Skip to content

ide: unify request completion methods

Bartlomiej Zolnierkiewicz linux-ide lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9ide: make ide_special_rq() BUG() on unknown requestsdrivers/ide/ide-io.c+1 -30 replies
2/9ide: add ide_end_rq()drivers/ide/ide-cd.c drivers/ide/ide-io.c include/linux/ide.h+15 -380 replies
3/9ide: sanitize ide_end_rq()drivers/ide/ide-cd.c drivers/ide/ide-io.c+17 -190 replies
4/9ide: pass error value to ide_complete_rq()drivers/ide/ide-atapi.c drivers/ide/ide-eh.c drivers/ide/ide-floppy.c +4 more+21 -180 replies
5/9ide: move rq->errors quirk out from ide_end_request()drivers/ide/ide-atapi.c drivers/ide/ide-cd.c drivers/ide/ide-disk.c +4 more+21 -50 replies
6/9ide: remove BUG() from ide_complete_rq()drivers/ide/ide-io.c include/linux/ide.h+7 -50 replies
7/9ide: pass number of bytes to complete to ide_complete_rq()drivers/ide/ide-atapi.c drivers/ide/ide-eh.c drivers/ide/ide-floppy.c +4 more+10 -100 replies
8/9ide: use ide_end_rq() in ide_complete_rq()drivers/ide/ide-io.c+1 -10 replies
9/9ide: remove ide_end_request()drivers/ide/ide-atapi.c drivers/ide/ide-cd.c drivers/ide/ide-devsets.c +8 more+37 -600 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] ide: unify request completion methods

Unify request completion methods so we (almost) always complete requests using ide_complete_rq(). As a nice side-effect it de-convolutes a lot of tricky code allowing further improvements later...

On top of pata-2.6 tree.

diffstat:

 drivers/ide/ide-atapi.c    |   20 +++-
 drivers/ide/ide-cd.c       |   18 ++--
 drivers/ide/ide-devsets.c  |    4 
 drivers/ide/ide-disk.c     |    4 
 drivers/ide/ide-dma.c      |    3 
 drivers/ide/ide-eh.c       |   14 ++-
 drivers/ide/ide-floppy.c   |   10 +-
 drivers/ide/ide-io.c       |  188 ++++++++++++++++-----------------------------
 drivers/ide/ide-tape.c     |    8 +
 drivers/ide/ide-taskfile.c |   10 +-
 include/linux/ide.h        |   10 +-
 11 files changed, 130 insertions(+), 159 deletions(-)