Skip to content

Fix resume breakage of USB PCI controllers behind cardbus bridges

Rafael J. Wysocki linux-pm lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1USB/PCI: Fix resume breakage of controllers behind cardbus bridgesdrivers/usb/core/hcd-pci.c drivers/usb/core/hcd.h drivers/usb/host/ehci-pci.c +2 more+2 -170 replies
1/1USB/PCI: Fix resume breakage of controllers behind cardbus bridgesdrivers/usb/core/hcd-pci.c drivers/usb/core/hcd.h drivers/usb/host/ehci-pci.c +2 more+2 -170 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] Fix resume breakage of USB PCI controllers behind cardbus bridges

[Sorry for resending, I forgot to send CCs to the mailing lists.]

Hi,

Unfortunately, we broke the resume of USB PCI controllers behind cardbus bridges by moving the restoration of their standard config registers to usb_hcd_pci_resume_early(). Namely, if USB PCI controller is behind a cardbus bridge, we're restoring its config registers too early, before the bridge becomes operational.

IMO in the future it's better to move the resume of cardbus bridges to the early resume phase (ie. before device interrupts will be enabled), but for 2.6.29 I think we should just go back to the 2.6.28 behavior, which is to call pci_restore_state() from usb_hcd_pci_resume(). The following patch does this.

Thanks,
Rafael