Skip to content

lenovo-sl-laptop : new driver for drivers/staging

Alexandre Rostovtsev linux-laptop lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3lenovo-sl-laptop : driver sourcedrivers/staging/lenovo-sl-laptop/lenovo-sl-laptop.c+1107 -00 replies
2/3lenovo-sl-laptop : documentationDocumentation/laptops/lenovo-sl-laptop.txt+130 -00 replies
3/3lenovo-sl-laptop : kconfig etc.drivers/staging/Kconfig drivers/staging/Makefile drivers/staging/lenovo-sl-laptop/Kconfig +1 more+20 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [0/3] lenovo-sl-laptop : new driver for drivers/staging

lenovo-sl-laptop is a new driver that adds support for hotkeys, bluetooth, LEDs and screen brightness on the Lenovo ThinkPad SL series laptops. [1] These laptops are not supported by the normal thinkpad_acpi driver because their firmware is quite different from the "real" ThinkPads. [2] After I wrote the SL series driver, I posted it on the linux thinkpad mailing list, asking whether it would be a good idea to try to merge it with thinkpad_acpi. Henrique de Moraes Holschuh, the thinkpad_acpi maintainer, replied that lenovo-sl-laptop should be kept separate from thinkpad_acpi. [3] Since then, I have received a number of emails from users who had tried the driver on their laptops and found that it works. Thus, I am posting it here for review and hope for eventual inclusion in staging.

Patches against 2.6.29-rc5 will be in following emails.

One important note concerning the backlight. Currently, the ACPI video driver has poor support for the ThinkPad SL series because their _BCL and _BQC methods violate the ACPI spec. Thus, the lenovo-sl-laptop driver adds optional (controlled via module parameter, default off) support for setting the backlight brightness.
Zhang Rui has stated that he will be working on making the ACPI video driver properly support the ThinkPad SL series and other laptops with non-standard backlight brightness interfaces. When he is finished, backlight functionality can probably be safely removed from lenovo-sl-laptop. [4]

Finally, a list of things that the driver does not currently support. There is no support for the hdaps accelerometer (and adding it would be difficult), no sensor information (I don't yet understand how to decode it), and no fan speed control.

[1] Homepage: http://github.com/tetromino/lenovo-sl-laptop
[2] http://mailman.linux-thinkpad.org/pipermail/linux-thinkpad/2009-January/046122.html
[3] http://mailman.linux-thinkpad.org/pipermail/linux-thinkpad/2009-January/046172.html
[4] http://bugzilla.kernel.org/show_bug.cgi?id=12249

 Documentation/laptops/lenovo-sl-laptop.txt         |  130 +++
 drivers/staging/Kconfig                            |    2 +
 drivers/staging/Makefile                           |    1 +
 drivers/staging/lenovo-sl-laptop/Kconfig           |   16 +
 drivers/staging/lenovo-sl-laptop/Makefile          |    1 +
 .../staging/lenovo-sl-laptop/lenovo-sl-laptop.c    | 1089 ++++++++++++++++++++
 6 files changed, 1239 insertions(+), 0 deletions(-)