Skip to content

ide-cd: use scatterlists also for PIO transfers

Bartlomiej Zolnierkiewicz linux-ide lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20ide: add support for arbitrary transfer lengths to ide_pio_bytes()drivers/ide/ide-taskfile.c+37 -360 replies
2/20ide: use PageHighMem() instead of ifdefs in ide_pio_bytes()drivers/ide/ide-taskfile.c+6 -80 replies
3/20ide-cd: remove dead URLsdrivers/ide/ide-cd.c+3 -60 replies
4/20ide-cd: use ide_end_rq() also for failed non-fs requestsdrivers/ide/ide-cd.c+4 -120 replies
5/20ide-cd: remove dead code from cdrom_decode_status()drivers/ide/ide-cd.c+0 -60 replies
6/20ide: remove needless ide_dump_status_no_sense() wrapperdrivers/ide/ide-cd.c+4 -130 replies
7/20ide-cd: remove no longer needed 'ignore' module parameterdrivers/ide/ide-cd.c+0 -120 replies
8/20ide-cd: factor out failed request completion from cdrom_end_request()drivers/ide/ide-cd.c+25 -220 replies
9/20ide-cd: unify ide_cd_do_request() exit pathsdrivers/ide/ide-cd.c+12 -160 replies
10/20ide-cd: move setting REQ_FAILED flag out from 'end_request' exit pathdrivers/ide/ide-cd.c+7 -50 replies
11/20ide-cd: unify cdrom_newpc_intr() exit pathsdrivers/ide/ide-cd.c+23 -252 replies
12/20ide-cd: remove cdrom_end_request()drivers/ide/ide-cd.c+47 -340 replies
13/20ide-cd: kill whole failed request in ide_cd_do_request()drivers/ide/ide-cd.c+1 -10 replies
14/20ide-cd: cleanup ide_cd_do_request()drivers/ide/ide-cd.c+6 -90 replies
15/20ide-cd: use scatterlists for PIO transfers (fs requests)drivers/ide/ide-cd.c drivers/ide/ide-taskfile.c include/linux/ide.h+50 -1050 replies
16/20ide-cd: fix non-SECTOR_SIZE-multiples PIO transfers for fs requestsdrivers/ide/ide-cd.c include/linux/ide.h+1 -400 replies
17/20ide-cd: merge ide_cd_prepare_rw_request() into cdrom_start_rw()drivers/ide/ide-cd.c+5 -160 replies
18/20ide-cd: use scatterlists for PIO transfers (non-fs requests)drivers/ide/ide-cd.c+30 -720 replies
19/20ide-cd: use common completion path for DMA requests in cdrom_newpc_intr()drivers/ide/ide-cd.c+1 -100 replies
20/20ide-cd: unify transfer padding in cdrom_newpc_intr()drivers/ide/ide-cd.c+11 -180 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/20] ide-cd: use scatterlists also for PIO transfers

The recent struct ide_cmd work allows us to finally convert ide-cd to use scatterlists for PIO transfers which fixes a long-standing bug with potential data integrity issue on write errors for PIO transfers and fs/pc requests (DMA transfers were never affected so it is not as serious issue as it might sound, still great that it is gone), greatly simiplifies the code and prepares it for a lot more improvements once struct ide_{atapi_pc,cmd} merge is done.

The patchset also contains fixes for some smaller issues uncovered by the main change and (as an added bonus) few unrelated minor cleanups.

[ Borislav, I hope that these changes don't interfere too much with your
current work and sorry for the rush (OTOH it should make things so much easier for us that the rush may be well justified)... ]

I tested that CD/DVD reading, CD writing and CD audio extraction still work after these changes (in both PIO and DMA modes). I also verified the behavior on the simulated media errors.

[ on top of pata-2.6 tree ]

diffstat:

 drivers/ide/ide-cd.c       |  638 +++++++++++++++------------------------------
 drivers/ide/ide-taskfile.c |   92 +++---
 include/linux/ide.h        |    9 
 3 files changed, 273 insertions(+), 466 deletions(-)