Skip to content

FSL eSDHC support

Anton Vorontsov linuxppc-dev lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 10 repliesIn review
  2. v211 patches 1 replySuperseded
  3. v113 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- Introduced MMC_SDHCI_IO_ACCESSORS Kconfig symbol. If not selected, SDHCI will just use PCI memory accessors unconditionally.
- Added MAINTAINERS entry.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11sdhci: Add support for bus-specific IO memory accessorsdrivers/mmc/host/Kconfig drivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+180 -810 replies
2/11sdhci: Split card-detection IRQs management from sdhci_init()drivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+62 -170 replies
3/11sdhci: Enable only relevant (DMA/PIO) interrupts during transfersdrivers/mmc/host/sdhci.c+14 -30 replies
4/11sdhci: Add support for card-detection pollingdrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+17 -20 replies
5/11sdhci: Add support for hosts reporting inverted write-protect statedrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+4 -00 replies
6/11sdhci: Add get_{max,timeout}_clock callbacksdrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+17 -70 replies
7/11sdhci: Add set_clock callback and a quirk for nonstandard clocksdrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+10 -00 replies
8/11sdhci: Add quirk for controllers that need small delays for PIOdrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+5 -00 replies
9/11sdhci: Add quirk for controllers that need IRQ re-init after resetdrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+9 -00 replies
10/11sdhci: Add quirk for forcing maximum block size to 2048 bytesdrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+15 -70 replies
11/11mmc: Add OpenFirmware bindings for SDHCI driverMAINTAINERS drivers/mmc/host/Kconfig drivers/mmc/host/Makefile +1 more+328 -09 replies

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by.

PatchArnd Bergmann
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/11] FSL eSDHC support

Hi all,

Here comes another version, let's hope that one is final. ;-)

Changes since v2:
- Introduced MMC_SDHCI_IO_ACCESSORS Kconfig symbol. If not selected, SDHCI will just use PCI memory accessors unconditionally.
- Added MAINTAINERS entry.

Changes since v1:
- "Add support for bus-specific IO memory accessors" patch no longer touches sdhci-pci. The changes were no longer needed since I dropped "Add type checking ..." patch back in RFCv2;
- Patch "Add support for hosts with strict 32 bit addressing" dropped. Now we handle the 32 bit magic in eSDHC's writew() accessor;
- Patch "Add quirk for controllers with max. block size up to 4096 bytes" replaced by "Add quirk for forcing maximum block size to 2048 bytes";
- SDHCI_INT_ALL_MASK changed to (unsigned int)-1;
- Addressed Pierre's comments in "Add support for card-detection polling" patch.

Changes since the third RFC:
- Use uninitialized_var() (suggested by Laurent Pinchart);
- Fixed a bug in eSDHC SDCLK prescaler calculations because of which we were over-clocking the SDCLK, and that caused CRC errors using some SD cards;
- Not a change, but some status: SDHS (50 MHz) cards were tested to NOT work (at least on MPC837x boards) -- this is to be investigated further. SDHC (> 4 GB) cards were not tested, yet.

Changes since the second RFC:
- Addressed all comments that were raised by Pierre Ossman. There were too many to mention them all, so here is the link:
http://lkml.org/lkml/2009/2/6/320

Changes since the first RFC:
- Use of_iomap() in sdhci-of.c (suggested by Arnd Bergmann). Also added Arnd's Acked-by: line for the sdhci-of patch.
- Kconfig help text improved (thanks to Matt Sealey and M. Warner Losh).
- In "sdhci: Add quirk to suppress PIO interrupts during DMA transfers"
patch: sdhci_init() now clears SDHCI_PIO_DISABLED flag, otherwise we won't disable PIO interrupts after suspend.
- New patch: "sdhci: Add type checking for IO memory accessors"

Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2