Skip to content

RFC mac80211: beacon filtering

Kalle Valo linux-wireless 2 versions – In review

Get series with b4
b4 am 20090314171234.11126.21125.stgit@tikku

Versions newest first · linked by author and title

  1. v2 RFC Latest4 patches 23 repliesIn review
  2. v1 RFC3 patches 20 repliesSuperseded

Changes in v2 from the cover letter

o rebase to 2.6.29-rc7-wl
o rename ieee80211_rx_trigger() to ieee80211_sta_rx_notify()
o move check for sta mode in ieee80211_sta_rx_notify() to rx.c
o move unicast check from rx.c to ieee80211_sta_rx_notify()
o add comment for setting last_beacon in ieee80211_rx_mgmt_assoc_resp()
o rename IEEE80211_HW_BEACON_FILTERING to IEEE80211_HW_BEACON_FILTER
o send probe request from ieee80211_beacon_loss_work()
o API documentation
o enable beacon filtering only when power save is enabled
o disable power save (and hence beacon filtering) while scanning to make it possible to have reliable scan results even when beacon filtering is enabled

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mac80211: decrease execution of the associated timernet/mac80211/ieee80211_i.h net/mac80211/mlme.c net/mac80211/rx.c+13 -07 replies
2/4mac80211: track beacons separately from the rx path activitynet/mac80211/ieee80211_i.h net/mac80211/mlme.c net/mac80211/rx.c+53 -335 replies
3/4mac80211: disable power save when scanninginclude/net/mac80211.h net/mac80211/scan.c+59 -72 replies
4/4mac80211: add beacon filtering supportinclude/net/mac80211.h net/mac80211/ieee80211_i.h net/mac80211/iface.c +1 more+61 -19 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC PATCH v2 0/4] mac80211: beacon filtering

Here's my proposal how to implement beacon filtering in mac80211. The basic idea is simple, the driver enables filtering whenever mac80211 enables power save and the driver calls ieee80211_beacon_loss() whenever hardware informs about beacon loss.

I have tested this with stlc45xx and based on simple tests this seems to work. For reference I earlier sent stlc45xx patch to this list.

v2:
o rebase to 2.6.29-rc7-wl
o rename ieee80211_rx_trigger() to ieee80211_sta_rx_notify()
o move check for sta mode in ieee80211_sta_rx_notify() to rx.c
o move unicast check from rx.c to ieee80211_sta_rx_notify()
o add comment for setting last_beacon in ieee80211_rx_mgmt_assoc_resp()
o rename IEEE80211_HW_BEACON_FILTERING to IEEE80211_HW_BEACON_FILTER
o send probe request from ieee80211_beacon_loss_work()
o API documentation
o enable beacon filtering only when power save is enabled
o disable power save (and hence beacon filtering) while scanning to make it possible to have reliable scan results even when beacon filtering is enabled

TODO:

o test with different hardware (without beacon filtering) to avoid regressions

---

Kalle Valo (4):
mac80211: add beacon filtering support
mac80211: disable power save when scanning
mac80211: track beacons separately from the rx path activity
mac80211: decrease execution of the associated timer

 include/net/mac80211.h     |   30 +++++++++--
 net/mac80211/ieee80211_i.h |    5 ++
 net/mac80211/iface.c       |    3 +
 net/mac80211/mlme.c        |  124 +++++++++++++++++++++++++++++++++-----------
 net/mac80211/rx.c          |    9 +++
 net/mac80211/scan.c        |   54 ++++++++++++++++++-
 6 files changed, 185 insertions(+), 40 deletions(-)