Skip to content

libfc and fcoe fixes for 2.6.29-rc

Robert Love linux-scsi 1 version New

Get series with b4
b4 am 20090227185430.25509.34309.stgit@fritz

Versions newest first

  1. v1 Latest24 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24libfc: Pass lport in exch_mgr_resetdrivers/scsi/libfc/fc_exch.c drivers/scsi/libfc/fc_lport.c drivers/scsi/libfc/fc_rport.c +1 more+8 -70 replies
2/24libfc: when rport goes away (re-plogi), clean up exchanges to/from rportdrivers/scsi/libfc/fc_rport.c+6 -10 replies
3/24libfc: handle RRQ exch timeoutdrivers/scsi/libfc/fc_exch.c+1 -10 replies
4/24libfc: fixed a soft lockup issue in fc_exch_recv_abtsdrivers/scsi/libfc/fc_exch.c+1 -10 replies
5/24libfc, fcoe: fixed locking issues with lport->lp_mutex around lport->link_statusdrivers/scsi/fcoe/fcoe_sw.c drivers/scsi/fcoe/libfcoe.c drivers/scsi/libfc/fc_fcp.c +2 more+30 -690 replies
6/24libfc: rport retry on LS_RJT from certain ELSdrivers/scsi/libfc/fc_exch.c drivers/scsi/libfc/fc_rport.c include/scsi/fc/fc_fs.h+69 -490 replies
7/24libfc: fixed a read IO data integrity issue when a IO data frame lostdrivers/scsi/libfc/fc_fcp.c+3 -30 replies
8/24libfc: exch mgr is freed while lport still retrying sequencesdrivers/scsi/libfc/fc_lport.c+2 -00 replies
9/24libfc: Don't violate transport template for rogue port creationdrivers/scsi/libfc/fc_disc.c drivers/scsi/libfc/fc_lport.c drivers/scsi/libfc/fc_rport.c +1 more+13 -50 replies
10/24libfc: correct RPORT_TO_PRIV usagedrivers/scsi/libfc/fc_disc.c+2 -20 replies
11/24libfc: rename rp to rdata in fc_disc_new_target()drivers/scsi/libfc/fc_disc.c+4 -40 replies
12/24libfc: check for err when recv and state is incorrectdrivers/scsi/libfc/fc_lport.c drivers/scsi/libfc/fc_rport.c+40 -400 replies
13/24libfc: Cleanup libfc_function_template commentsinclude/scsi/libfc.h+66 -410 replies
14/24libfc, fcoe: Fix kerneldoc commentsdrivers/scsi/fcoe/fc_transport_fcoe.c drivers/scsi/fcoe/fcoe_sw.c drivers/scsi/fcoe/libfcoe.c +5 more+252 -2570 replies
15/24libfc, fcoe: Cleanup function formatting and minor typosdrivers/scsi/fcoe/fc_transport_fcoe.c drivers/scsi/fcoe/libfcoe.c drivers/scsi/libfc/fc_exch.c +1 more+20 -200 replies
16/24libfc, fcoe: Remove unnecessary cast by removing inline wrapperdrivers/scsi/fcoe/fcoe_sw.c drivers/scsi/fcoe/libfcoe.c include/scsi/libfcoe.h+8 -140 replies
17/24fcoe: Use setup_timer() and mod_timer()drivers/scsi/fcoe/libfcoe.c+3 -50 replies
18/24fcoe: Correct fcoe_transports initialization vs. registrationdrivers/scsi/fcoe/fc_transport_fcoe.c drivers/scsi/fcoe/fcoe_sw.c+5 -30 replies
19/24libfc: do not change the fh_rx_id of a recevied framedrivers/scsi/libfc/fc_exch.c+0 -130 replies
20/24fcoe: ETH_P_8021Q is already in if_ether and fcoe is not using it anywayinclude/scsi/fc/fc_fcoe.h+0 -40 replies
21/24fcoe: fix kfree(skb)drivers/scsi/fcoe/libfcoe.c+1 -10 replies
22/24fcoe: Out of order tx frames was causing several check condition SCSI statusdrivers/scsi/fcoe/fcoe_sw.c drivers/scsi/fcoe/libfcoe.c include/scsi/libfcoe.h+23 -240 replies
23/24fcoe: fix handling of pending queue, prevent out of order frames (v3)drivers/scsi/fcoe/libfcoe.c+24 -570 replies
24/24fcoe: Change fcoe receive thread nice value from 19 (lowest priority) to -20drivers/scsi/fcoe/libfcoe.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/24] libfc and fcoe fixes for 2.6.29-rc

The following series implements fixes for Open-FCoE (libfc and fcoe). All of these patches had been sent to linux-scsi previously, with the exception of the last 6 patches, which are new.

Of the last 6 patches one is a patch mailed to linux-scsi, not from Open-FCoE.org, that has not been applied yet. That patch is-

Roel Kluin - fcoe: fix kfree(skb)

Also, the very last patch converts the FCoE Rx threads to a nice value of -20. I sought advice on linux-scsi to determine a good value for these threads, but didn't get feedback. Since other FC driver threads use -20, this is the value I chose. If this is not a good starting value, then please do not apply the patch, but I would appreciate feedback as to a better value.

This patch set is based on Linus' 2.6.29-rc6 tree. I chose this tree becuase it is more current than rc-fixes. If a rebase and resend is let me know.

---

Abhijeet Joglekar (2):
libfc: when rport goes away (re-plogi), clean up exchanges to/from rport
libfc: Pass lport in exch_mgr_reset

Chris Leech (2):
fcoe: fix handling of pending queue, prevent out of order frames (v3)
libfc: rport retry on LS_RJT from certain ELS

Robert Love (11):
fcoe: Change fcoe receive thread nice value from 19 (lowest priority) to -20
fcoe: Correct fcoe_transports initialization vs. registration
fcoe: Use setup_timer() and mod_timer()
libfc, fcoe: Remove unnecessary cast by removing inline wrapper libfc, fcoe: Cleanup function formatting and minor typos
libfc, fcoe: Fix kerneldoc comments
libfc: Cleanup libfc_function_template comments
libfc: check for err when recv and state is incorrect
libfc: rename rp to rdata in fc_disc_new_target()
libfc: correct RPORT_TO_PRIV usage
libfc: Don't violate transport template for rogue port creation

Roel Kluin (1):
fcoe: fix kfree(skb)

Steve Ma (1):
libfc: exch mgr is freed while lport still retrying sequences

Vasu Dev (5):
fcoe: Out of order tx frames was causing several check condition SCSI status
libfc: fixed a read IO data integrity issue when a IO data frame lost libfc, fcoe: fixed locking issues with lport->lp_mutex around lport->link_status
libfc: fixed a soft lockup issue in fc_exch_recv_abts
libfc: handle RRQ exch timeout

Yi Zou (2):
fcoe: ETH_P_8021Q is already in if_ether and fcoe is not using it anyway
libfc: do not change the fh_rx_id of a recevied frame

 drivers/scsi/fcoe/fc_transport_fcoe.c |   91 +++++----
 drivers/scsi/fcoe/fcoe_sw.c           |   56 +++---
 drivers/scsi/fcoe/libfcoe.c           |  318 ++++++++++++++-------------------
 drivers/scsi/libfc/fc_disc.c          |   63 +++----
 drivers/scsi/libfc/fc_exch.c          |   32 +--
 drivers/scsi/libfc/fc_fcp.c           |   56 +++---
 drivers/scsi/libfc/fc_lport.c         |  173 ++++++++----------
 drivers/scsi/libfc/fc_rport.c         |  197 ++++++++++++--------
 include/scsi/fc/fc_fcoe.h             |    4 
 include/scsi/fc/fc_fs.h               |    5 +
 include/scsi/libfc.h                  |  138 ++++++++------
 include/scsi/libfcoe.h                |    9 -
 12 files changed, 551 insertions(+), 591 deletions(-)
Signature · 1 line
//Rob