Skip to content

RFC Rework disabling of interrupts during suspend-resume

Rafael J. Wysocki linux-pm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 28 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4PM: Rework handling of interrupts during suspend-resume (rev. 4)arch/x86/kernel/apm_32.c drivers/base/power/main.c drivers/base/sys.c +9 more+170 -410 replies
1/4PM: Rework handling of interrupts during suspend-resume (rev. 4)arch/x86/kernel/apm_32.c drivers/base/power/main.c drivers/base/sys.c +9 more+170 -4120 replies
2/4PM: Change suspend code orderingkernel/power/main.c+22 -160 replies
2/4PM: Change suspend code orderingkernel/power/main.c+22 -163 replies
3/4PM: Change hibernation code orderingkernel/power/disk.c+61 -480 replies
3/4PM: Change hibernation code orderingkernel/power/disk.c+61 -480 replies
4/4kexec: Change kexec jump code orderingkernel/kexec.c+9 -100 replies
4/4kexec: Change kexec jump code orderingkernel/kexec.c+9 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC][PATCH 0/4] Rework disabling of interrupts during suspend-resume

Hi,

The following patches modifiy the way in which we handle disabling interrupts during suspend and enabling them during resume. They also change the ordering of the core suspend and hibernation code.

Namely, interrupts are currently disabled on the boot CPU as soon as the nonboot CPUs have been disabled, which doesn't allow device drivers' "late" suspend and "early" resume callbacks to sleep. Among other things this means they cannot execute ACPI AML routines, which leads to problems with suspend-resume of PCI devices, as recently discussed.

1/4 modifies the [suspend|hibernation] and resume code, as well as the other code using the device PM framework, so that device drivers will not receive interrupts during the "late" suspend phase, although interrupts will only be disabled on the CPU right before calling sysdev_suspend() (and analogously during resume). [Ingo, I didn't add your ACK to the patch, because it's changed since you saw it last time.]

2/4 - 4/4 modify the suspend, hibernation and kexec jump code, respectively, so that the "late" phase of suspending devices will happen before the platform "prepare" callback and the disabling of nonboot CPUs (and analogously during resume).

Comments welcome.

Thanks,
Rafael