ocfs2: two bug fixes about xattr and inline-data
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ocfs2: reserve xattr block for directory inode in mknod | +0 | 0 replies | |
| 2/2 | ocfs2: fix check condition of max inline data | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Ocfs2-devel] [PATCH 0/2] ocfs2: two bug fixes about xattr and inline-data
Quoted 1 line · Tiger Yang
I found two serious bugs about xattr and inline-data.
Tristan,
Can you add tests for this in the xattr suite? Thanks!
Joel
Quoted 17 lines
the first bug:
inocfs2_mknod(), we check and found the ACL or security xattr entry could be set into inode inocfs2_calc_xattr_init(), then don't reserve block for them. But inocfs2_mknod_locked(), if we found ocfs2 support inline-data, then setid_countwith themax_inline_data. After that, we set acl/security xattr entry inocfs2_init_acl()orocfs2_init_security_set(), but in there we found inode is full, then panic atocfs2_claim_metadatainocfs2_xattr_block_set.the second bug:
we don't check inline xattr inocfs2_try_to_write_inline_data(), so the inline data may overwrite the xattr entries which have already in inode.thanks,
tiger
Signature · 9 lines
"Here's something to think about: How come you never see a headline like ``Psychic Wins Lottery''?" - Jay Leno Joel Becker Principal Software Developer Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127