Skip to content

mmc-twl4030 loses twl4030-dependency

David Brownell linux-omap 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5regulator: enumerate voltagesdrivers/regulator/core.c include/linux/regulator/consumer.h include/linux/regulator/driver.h+124 -01 reply
2/5regulator: twl4030 voltage enumerationdrivers/regulator/twl4030-regulator.c+23 -391 reply
3/5regulator: twl4030 voltage enumeration cleanupdrivers/regulator/twl4030-regulator.c+9 -71 reply
4/5MMC: regulator utilitiesdrivers/mmc/core/core.c include/linux/mmc/host.h+105 -01 reply
5/5mmc-twl4030 uses regulator frameworkarch/arm/mach-omap2/mmc-twl4030.c arch/arm/mach-omap2/mmc-twl4030.h drivers/mmc/host/omap_hsmmc.c+100 -1719 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchMark BrownPierre Ossman
1/5A-b
2/5A-b
3/5
4/5A-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 2.6.29-rc7-omap 0/5] mmc-twl4030 loses twl4030-dependency

The last dependency of that code on twl4030 specific behavior was coupled to regulator usage ... and, hey, there's a regulator framework to hide such details!

The first four of these patches are from the regulator-next tree:

- regulator: enumerate voltages
- regulator: twl4030 voltage enumeration
- regulator: twl4030 voltage enumeration cleanups
- MMC: regulator utilities

More precisely ... the first three are, but the wrong version of the fourth got merged; that should get sorted out soonish.

The last patch does the magic:

- mmc-twl4030 uses regulator framework

This works if the boards have hooked up their regulators to the MMC devices. Beagle does that; so does the 3430 SDP (which has a second 1.8V SD/MMCplus slot). I'll resend a patch doing that for Overo.

So for example two of Adrian's patches from yesterday are now subsumed by the regulator framework. To have MMC2 hook up to an eMMC chip that needs VccQ for interface level shifting, just hook up the "aux" supply to that MMC device. To have it use the VAUX3 supply instead of VMMC2, just be sure to hook up the right regulator.