Skip to content

Open-FCoE fixes and features for 2.6.30 merge window

Robert Love linux-scsi 1 version In review

Get series with b4
b4 am 20090317184124.22987.65368.stgit@fritz

Versions newest first

  1. v1 Latest14 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14fcoe: Initialize all possilbe skb_queue(s) when module is loadeddrivers/scsi/fcoe/libfcoe.c include/scsi/libfcoe.h+13 -100 replies
2/14fcoe: Use percpu kernel funcs for struct fcoe_percpu_sdrivers/scsi/fcoe/libfcoe.c include/scsi/libfcoe.h+43 -520 replies
3/14fcoe: Use per-CPU kernel function for dev_stats instead of an arraydrivers/scsi/fcoe/fcoe_sw.c drivers/scsi/fcoe/libfcoe.c drivers/scsi/libfc/fc_fcp.c +2 more+53 -1451 reply
4/14fcoe: create/destroy fcoe Rx threads on CPU hotplug eventsdrivers/scsi/fcoe/libfcoe.c+199 -473 replies
5/14fcoe: prep work to completely remove fc_transport_fcoe codedrivers/scsi/fcoe/fcoe_sw.c drivers/scsi/fcoe/libfcoe.c include/scsi/libfcoe.h+12 -535 replies
6/14fcoe: removes fc_transport_fcoe.[ch] code filesdrivers/scsi/fcoe/Makefile drivers/scsi/fcoe/fc_transport_fcoe.c include/scsi/fc_transport_fcoe.h+1 -4992 replies
7/14fcoe: removes default sw transport code file fcoe_sw.cdrivers/scsi/fcoe/Makefile drivers/scsi/fcoe/fcoe_sw.c drivers/scsi/fcoe/libfcoe.c +1 more+481 -5392 replies
8/14fcoe: renames libfcoe.c to fcoe.c as the only fcoe module filedrivers/scsi/fcoe/Makefile drivers/scsi/fcoe/fcoe.c drivers/scsi/fcoe/libfcoe.c+1972 -19772 replies
9/14fcoe, libfc, scsi: adds libfcoe moduledrivers/scsi/Kconfig drivers/scsi/Makefile drivers/scsi/fcoe/Makefile +3 more+35 -30 replies
10/14fcoe: moves common FCoE library API functions to libfcoe moduledrivers/scsi/fcoe/fcoe.c drivers/scsi/fcoe/libfcoe.c+67 -640 replies
11/14fcoe: cleans up libfcoe.h and adds fcoe.h for fcoe moduledrivers/scsi/fcoe/fcoe.c drivers/scsi/fcoe/fcoe.h include/scsi/libfcoe.h+105 -1430 replies
12/14fcoe, libfc: fix double fcoe_softc memory allocdrivers/scsi/fcoe/fcoe.c include/scsi/libfc.h+19 -360 replies
13/14fcoe: Add a header file defining the FIP protocol for FCoE.include/scsi/fc/fc_fip.h+237 -00 replies
14/14fcoe, libfcoe: Add support for FIP. FCoE discovery and keep-alive.drivers/scsi/fcoe/fcoe.c drivers/scsi/fcoe/fcoe.h drivers/scsi/fcoe/libfcoe.c +1 more+1499 -1370 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/14] Open-FCoE fixes and features for 2.6.30 merge window

The following series implements a few fixes, some preparation work and the implementation of FIP.

1) Fix of CPU hotplug handling.

2) Removal of fc_transport_fcoe.[ch]. This code was written so a LLD could load a transport for Ethernet devices that support FCoE offloads. This aproach was discarded in favor of directly providing offload capabilities through netdev. FCoE offload patches have been Ack'd by netdev and are in the scsi-misc tree already. In this set we just clean up the previous and unused FCoE transport method.

3) fcoe/* reorgainzation. Since both FIP and fnic are targeting the 2.6.30 merge window we wanted to do some cleanup of the fcoe layer. We've better defined each module so that fcoe.ko will only have the netdev related SW implementation (fnic does not use) and libfcoe.ko which will have common FCoE routines available to all FCoE LLDs.

4) FIP implementation. FIP == FCoE Initialization Protocol. This is a new standard way to discover FCoE capable switches. This code becomes the majority of libfcoe.ko. These patches had previously been sent to linux-scsi. This series resends them as they've been slightly modified to better fit into the reorganization. Functionality is the same as previously posted.

This patchset is built on scsi-misc-2.6 and are intended for 2.6.30.

---

Joe Eykholt (2):
fcoe, libfcoe: Add support for FIP. FCoE discovery and keep-alive.
fcoe: Add a header file defining the FIP protocol for FCoE.

Robert Love (4):
fcoe: create/destroy fcoe Rx threads on CPU hotplug events
fcoe: Use per-CPU kernel function for dev_stats instead of an array
fcoe: Use percpu kernel funcs for struct fcoe_percpu_s
fcoe: Initialize all possilbe skb_queue(s) when module is loaded

Vasu Dev (8):
fcoe, libfc: fix double fcoe_softc memory alloc
fcoe: cleans up libfcoe.h and adds fcoe.h for fcoe module
fcoe: moves common FCoE library API functions to libfcoe module fcoe, libfc, scsi: adds libfcoe module
fcoe: renames libfcoe.c to fcoe.c as the only fcoe module file
fcoe: removes default sw transport code file fcoe_sw.c
fcoe: removes fc_transport_fcoe.[ch] code files
fcoe: prep work to completely remove fc_transport_fcoe code

 drivers/scsi/Kconfig                  |    8 
 drivers/scsi/Makefile                 |    1 
 drivers/scsi/fcoe/Makefile            |    8 
 drivers/scsi/fcoe/fc_transport_fcoe.c |  443 -------
 drivers/scsi/fcoe/fcoe.c              | 1865 ++++++++++++++++++++++++++++
 drivers/scsi/fcoe/fcoe.h              |   75 +
 drivers/scsi/fcoe/fcoe_sw.c           |  561 --------
 drivers/scsi/fcoe/libfcoe.c           | 2216 +++++++++++++++------------------
 drivers/scsi/libfc/fc_fcp.c           |   10 
 drivers/scsi/libfc/fc_lport.c         |   11 
 include/scsi/fc/fc_fip.h              |  237 ++++
 include/scsi/fc_transport_fcoe.h      |   54 -
 include/scsi/libfc.h                  |   45 +
 include/scsi/libfcoe.h                |  227 ++-
 14 files changed, 3396 insertions(+), 2365 deletions(-)
 delete mode 100644 drivers/scsi/fcoe/fc_transport_fcoe.c
 create mode 100644 drivers/scsi/fcoe/fcoe.c
 create mode 100644 drivers/scsi/fcoe/fcoe.h
 delete mode 100644 drivers/scsi/fcoe/fcoe_sw.c
 create mode 100644 include/scsi/fc/fc_fip.h
 delete mode 100644 include/scsi/fc_transport_fcoe.h
Signature · 1 line
//Rob