Skip to content

mac80211: beacon filtering

Kalle Valo linux-wireless 1 version In review

Get series with b4
b4 am 20090322195619.26460.48292.stgit@tikku

Versions newest first

  1. v4 Latest5 patches 9 repliesIn review

Changes in v4 from the cover letter

o remove hw parameter from ieee80211_beacon_loss()
o don't call the patchset RFC anymore

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mac80211: decrease execution of the associated timernet/mac80211/ieee80211_i.h net/mac80211/mlme.c net/mac80211/rx.c+20 -00 replies
2/5mac80211: track beacons separately from the rx path activitynet/mac80211/ieee80211_i.h net/mac80211/mlme.c net/mac80211/rx.c+52 -320 replies
3/5mac80211: disable power save when scanninginclude/net/mac80211.h net/mac80211/scan.c+69 -70 replies
4/5cfg80211: add feature to hold bssinclude/net/cfg80211.h net/wireless/core.h net/wireless/scan.c+46 -10 replies
5/5mac80211: add beacon filtering supportDocumentation/DocBook/mac80211.tmpl include/net/mac80211.h net/mac80211/ieee80211_i.h +2 more+92 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/5] mac80211: beacon filtering

Here's my proposal how to implement beacon filtering in mac80211. The basic idea is simple, the driver enables filtering whenever mac80211 enables power save and the driver calls ieee80211_beacon_loss() whenever hardware informs about beacon loss.

I have tested this with stlc45xx (with beacon filtering) and iwl3945 (without beacon filtering) and based on simple tests this seems to work. For reference I'll send the stlc45xx patch as a followup.

v4:

o remove hw parameter from ieee80211_beacon_loss()
o don't call the patchset RFC anymore

v3:
o rebase to 2.6.29-rc8-wl
o add cfg80211_hold_bss() and cfg80211_unhold_bss() to avoid loosing the bss struct when beacon filter is enabled
o fix bug to use !IEEE80211_HW_PS_NULLFUNC_STACK both in ieee80211_scan_ps_enable() and ieee80211_scan_ps_disable(), also improve comments
o fix the indentation in ieee80211_associated(), not visible in patch anymore:

    mod_timer(&ifmgd->timer, jiffies +
    -				      IEEE80211_MONITORING_INTERVAL);
    +			  IEEE80211_MONITORING_INTERVAL);

o add vif parameter to void ieee80211_beacon_loss()
o more documentation about filtering, and especially about checksumming
o document why multicast check is needed in ieee80211_sta_rx_notify()
o beacon filter is only enabled when power save is enabled, take this into account in ieee80211_associated()

v2:
o rebase to 2.6.29-rc7-wl
o rename ieee80211_rx_trigger() to ieee80211_sta_rx_notify()
o move check for sta mode in ieee80211_sta_rx_notify() to rx.c
o move unicast check from rx.c to ieee80211_sta_rx_notify()
o add comment for setting last_beacon in ieee80211_rx_mgmt_assoc_resp()
o rename IEEE80211_HW_BEACON_FILTERING to IEEE80211_HW_BEACON_FILTER
o send probe request from ieee80211_beacon_loss_work()
o API documentation
o enable beacon filtering only when power save is enabled
o disable power save (and hence beacon filtering) while scanning to make it possible to have reliable scan results even when beacon filtering is enabled

TODO:

(none)

For the future:

o configuration for beacon filter (beacon misses * beacon interval should be constant?)
o don't run ieee80211_associated() in data idle period

---

Kalle Valo (5):
mac80211: add beacon filtering support
cfg80211: add feature to hold bss
mac80211: disable power save when scanning
mac80211: track beacons separately from the rx path activity
mac80211: decrease execution of the associated timer

 Documentation/DocBook/mac80211.tmpl |    6 ++
 include/net/cfg80211.h              |   18 +++++
 include/net/mac80211.h              |   45 ++++++++++-
 net/mac80211/ieee80211_i.h          |    5 +
 net/mac80211/iface.c                |    3 +
 net/mac80211/mlme.c                 |  139 +++++++++++++++++++++++++++--------
 net/mac80211/rx.c                   |    9 ++
 net/mac80211/scan.c                 |   64 ++++++++++++++++
 net/wireless/core.h                 |    2 +
 net/wireless/scan.c                 |   27 +++++++
 10 files changed, 278 insertions(+), 40 deletions(-)