RFC Make radeonfb use PCI PM core for suspendig device (was: Re: [RFC][PATCH] PCI PM: Be extra careful when changing power states of devices)
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest2 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | PCI PM: Introduce __pci_set_power_state()drivers/ include/ | +54 | 0 replies | |
| 1/2 | PCI PM: Introduce __pci_set_power_state()drivers/ include/ | +54 | 3 replies | |
| 1/2 | PCI PM: Export platform_pci_set_power_state()drivers/ include/ | +40 | 0 replies | |
| 1/2 | PCI PM: Export platform_pci_set_power_state()drivers/ include/ | +40 | 0 replies | |
| 2/2 | radeonfb: Avoid open coding of PCI PM operationsdrivers/ | +3 | 0 replies | |
| 2/2 | radeonfb: Avoid open coding of PCI PM operationsdrivers/ | +3 | 0 replies | |
| 2/2 | radeonfb: Use platform_pci_set_power_state()drivers/ | +1 | 0 replies | |
| 2/2 | radeonfb: Use platform_pci_set_power_state()drivers/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC][PATCH 0/2] Make radeonfb use PCI PM core for suspendig device (was: Re: [RFC][PATCH] PCI PM: Be extra careful when changing power states of devices)
Quoted 11 lines · Rafael J. Wysocki
From: Rafael J. Wysocki <[email protected]>
The story in http://bugzilla.kernel.org/show_bug.cgi?id=12846 shows that setting the power state of a PCI device by
pci_raw_set_power_state()may sometimes fail. For this reason,pci_raw_set_power_state()should not assume that the power state of the device has actually changed after writing into its PMCSR. Instead, it should read the value from there and use it to updatedev->current_state. It also is useful to print a warning if the device's power state hasn't changed as expected.
Quoted 2 lines
Signed-off-by Rafael J. Wysocki <[email protected]>---
OK, since the Ben's radeonfb fix for bug #12846 has been merged, I'd like to do something a bit different.
Patch 1/2 introduces __pci_set_power_state() that will allow the radeonfb driver not to open code PCI PM operations.
Patch 2/2 makes the driver use __pci_set_power_state().
Comments welcome.
Thanks,
Rafael