Skip to content

RFC sysfs: allow suicide

Alex Chiang lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3sysfs: make the sysfs_addrm_cxt->removed list FIFOfs/sysfs/dir.c fs/sysfs/sysfs.h+6 -30 replies
2/3sysfs: add blocking notifier to prohibit module unloadfs/sysfs/file.c fs/sysfs/mount.c fs/sysfs/sysfs.h+79 -00 replies
3/3sysfs: care-free suicide for sysfs filesfs/sysfs/dir.c fs/sysfs/file.c fs/sysfs/sysfs.h+67 -31 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/3] sysfs: allow suicide

Hi all,

This is a refreshed version of the patch series Tejun posted quite a while ago that allowed sysfs attributes to commit suicide directly:

	http://thread.gmane.org/gmane.linux.kernel/582130/

I'm dusting this off (with Tejun's approval) because of recent changes I introduced into the PCI core, which allow for logical hotplug of any device in the system (via sysfs):

	http://thread.gmane.org/gmane.linux.kernel.pci/3713/

My removal mechanism uses the much-hated sysfs_schedule_callback() mechanism, and indeed, even some light testing has already shown some drawbacks, namely we produce at least one false positive in lockdep.

I'm taking a two-prong approch here. The first step is to modify sysfs_schedule_callback() and get it off the global work queue. This will eliminate false positives in lockdep, and also stop us from hogging the shared work queue with a long-running ->remove event, such as removing a PCI bridge near the root of the hierarchy with lots of devices underneath. I'm having Kenji test this patch right now, since I'd like to get it fixed for the current merge window:

	http://thread.gmane.org/gmane.linux.kernel.pci/3713/focus=3756

[note: Greg, if Kenji's testing is successful, I plan on sending that patch as another .30 change]

The other prong is getting discussion going on this patch series again.

The most contentious part is patch 1/3, wherein sysfs abuses the module notifier call chain, and basically prevents all module unloads until suicidal sysfs attributes have completed.

This is poison of a different flavor from last time. The earlier version of this series modified the module API and created an interface that allowed anyone to inhibit module unload.

This time, only sysfs is allowed to be so... special. Which is a slight improvement, but the question as to whether sysfs should be allowed to do something like this is unresolved.

I'd like to get Rusty's opinion on this approach; I didn't see anything in the archives from previous threads.

A secondary minor concern is the impurity that I've introduced into sysfs, but I think most of the folks copied here would agree that it's a worthwhile tradeoff if we can eliminate the callback mechanism.

Finally, please note that I didn't refresh the 4th patch in the original series, the good one that actually removes all the cruft. I figured we could discuss the module unload inhibition first, and in the meantime, I could let some of the merge activity settle out before touching the callsites.

Comments appreciated.

Thanks.

/ac

---

Alex Chiang (1):
sysfs: add blocking notifier to prohibit module unload

Tejun Heo (2):
sysfs: care-free suicide for sysfs files
sysfs: make the sysfs_addrm_cxt->removed list FIFO

 fs/sysfs/dir.c   |    9 +++-
 fs/sysfs/file.c  |  135 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
 fs/sysfs/mount.c |    8 +++
 fs/sysfs/sysfs.h |    6 ++
 4 files changed, 152 insertions(+), 6 deletions(-)