Skip to content

RFC sched: find_busiest_group() cleanup

Gautham R Shenoy lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest11 patches 21 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11sched: Simple helper functions for find_busiest_group()kernel/sched.c+43 -121 reply
2/11sched: Fix indentations in find_busiest_group using gotos.kernel/sched.c+17 -151 reply
3/11sched: Define structure to store the sched_group statistics for fbg()kernel/sched.c+46 -331 reply
4/11sched: Create a helper function to calculate sched_group stats for fbg()kernel/sched.c+100 -751 reply
5/11sched: Define structure to store the sched_domain statistics for fbg()kernel/sched.c+121 -861 reply
6/11sched: Create a helper function to calculate sched_domain stats for fbg()kernel/sched.c+73 -441 reply
7/11sched: Create helper to calculate small_imbalance in find_busiest_group.kernel/sched.c+70 -611 reply
8/11sched: Create a helper function to calculate imbalance.kernel/sched.c+45 -331 reply
9/11sched: Optimize the !power_savings_balance during find_busiest_group.kernel/sched.c+14 -91 reply
10/11sched: Refactor the power savings balance code.kernel/sched.c+153 -831 reply
11/11sched: Add comments to find_busiest_group() function.kernel/sched.c+42 -89 replies

Reviews trailers per patch

10 of 11 patches have a Reviewed-by or Acked-by.

PatchPeter Zijlstra
1/11A-b
2/11A-b
3/11A-b
4/11Aked-by
5/11A-b
6/11A-b
7/11A-b
8/11A-b
9/11A-b
10/11A-b
11/11A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 00/11] sched: find_busiest_group() cleanup

Hi,

This patchset contains the cleanup of the humongous find_busiest_group() function.

Vaidy had tried a hand at this before. His approach can be found here:
http://lkml.org/lkml/2008/9/24/201 and
http://lkml.org/lkml/2008/10/9/176

Though the code in this patchset has been written from scratch I have reused some of the ideas that Vaidy had originally proposed. Credit has been given whereever it is due :)

The patches in this series are incremental. Each one is a functional patch, which compiles fine.

The steps followed in the cleanup are as follows:
- Fix indentations.

- Group variables that serve a common high-level purpose into a single structure.

- Use helper functions to perform all the calculatations, like calculating the sched_domain and sched_group statistics, calculating the imbalance, etc.

- Move the power_savings_balance part, which depends on (CONFIG_SCHED_MC || CONFIG_SCHED_SMT) into a different section, thereby eliminating the #ifdef jungle in helper functions.

- Add /** style comments for all the functions, including find_busiest_group()

- Add additional comments whereever appropriate.

After applying all the patches, the size of find_busiest_group() goes down from 313 lines to 76 lines. Of course, there are the helpers, but effort has been put to keep all the helper functions within the 80 line limit.

Any feedback on the patches and how the functionality can be tested is greatly appreciated.

---

Gautham R Shenoy (11):
sched: Add comments to find_busiest_group() function.
sched: Refactor the power savings balance code.
sched: Optimize the !power_savings_balance during find_busiest_group.
sched: Create a helper function to calculate imbalance.
sched: Create helper to calculate small_imbalance in find_busiest_group.
sched: Create a helper function to calculate sched_domain stats for fbg()
sched: Define structure to store the sched_domain statistics for fbg()
sched: Create a helper function to calculate sched_group stats for fbg()
sched: Define structure to store the sched_group statistics for fbg()
sched: Fix indentations in find_busiest_group using gotos.
sched: Simple helper functions for find_busiest_group()

 kernel/sched.c |  765 ++++++++++++++++++++++++++++++++++++++------------------
 1 files changed, 515 insertions(+), 250 deletions(-)
Signature · 2 lines
Thanks and Regards
gautham.