Skip to content

Address review comments for fnic

Abhijeet Joglekar linux-scsi 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fnic: Change link transition handlingdrivers/scsi/fnic/fnic.h drivers/scsi/fnic/fnic_fcs.c drivers/scsi/fnic/fnic_main.c+68 -550 replies
2/3fnic: Change FCS frame handling to use skb queues and no eventsdrivers/scsi/fnic/fnic.h drivers/scsi/fnic/fnic_fcs.c drivers/scsi/fnic/fnic_main.c +1 more+39 -1200 replies
3/3fnic: Use shost_printk and print host no in print messagesdrivers/scsi/fnic/fnic.h drivers/scsi/fnic/fnic_fcs.c drivers/scsi/fnic/fnic_isr.c +3 more+234 -1950 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Address review comments for fnic

The following series addresses Mike C.'s review comments for fnic:
1) Use static workQ item per fnic for link transitions
2) Use static workQ item and skb queue per fnic for FCS frames
3) Use shost_printk to print host_no instead of printing fnic_no

(1) and (2) address the comment that allocating memory in the critical path for link transitions and FCS frames (fabric login etc) is not good since failure in memory allocation can prove fatal. The patches get rid of the event structure and its allocation, and instead use static workQ items.

---

Abhijeet Joglekar (3):
fnic: Use shost_printk and print host no in print messages
fnic: Change FCS frame handling to use skb queues and no events
fnic: Change link transition handling

 drivers/scsi/fnic/fnic.h      |   45 +++-------
 drivers/scsi/fnic/fnic_fcs.c  |  155 +++++++++++++++++++--------------
 drivers/scsi/fnic/fnic_isr.c  |   15 ++-
 drivers/scsi/fnic/fnic_main.c |  186 +++++++++++++++-------------------------
 drivers/scsi/fnic/fnic_res.c  |   80 ++++++++++-------
 drivers/scsi/fnic/fnic_scsi.c |  192 ++++++++++++++++++++---------------------
 6 files changed, 322 insertions(+), 351 deletions(-)
Signature · 1 line
Signature