Skip to content

improve ctnetlink event reliability

Pablo Neira Ayuso netfilter-devel 1 version In review

Get series with b4
b4 am 20090327093822.8259.50902.stgit@Decadence

Versions newest first

  1. v1 Latest5 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5netfilter: conntrack: remove events flags from userspace exposed fileinclude/linux/netfilter/nf_conntrack_common.h include/net/netfilter/nf_conntrack_ecache.h+69 -690 replies
2/5netfilter: conntrack: use nf_ct_kill() to destroy conntracksnet/netfilter/nf_conntrack_core.c net/netfilter/nf_conntrack_pptp.c+3 -80 replies
3/5netfilter: conntrack: don't report events on module removalinclude/net/netfilter/nf_conntrack.h net/netfilter/nf_conntrack_core.c net/netfilter/nf_conntrack_netlink.c+14 -90 replies
4/5conntrack: ecache: move event cache to conntrack extension infrastructureinclude/net/netfilter/nf_conntrack_ecache.h include/net/netfilter/nf_conntrack_extend.h include/net/netns/conntrack.h +6 more+202 -1225 replies
5/5ctnetlink: optional reliable event deliveryinclude/net/netfilter/nf_conntrack_core.h include/net/netfilter/nf_conntrack_ecache.h include/net/netns/conntrack.h +7 more+157 -704 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] improve ctnetlink event reliability

Hi Patrick,

This is more like a RFC patch.

The following series are targeted to improve ctnetlink reliability. I think that the first three patches can be applied safely as they are merely cleanups. The last two patches may be more controversial, specifically 4/5 reworks the event caching infrastructure to go over the conntrack extension infrastructure, thus, leading to more memory consumption per conntrack. I needed this to add optional reliable event delivery more cleanly.

Wait for you feedback.

---

Pablo Neira Ayuso (5):
ctnetlink: optional reliable event delivery
conntrack: ecache: move event cache to conntrack extension infrastructure
netfilter: conntrack: don't report events on module removal
netfilter: conntrack: use nf_ct_kill() to destroy conntracks
netfilter: conntrack: remove events flags from userspace exposed file

 include/linux/netfilter/nf_conntrack_common.h |   69 --------
 include/net/netfilter/nf_conntrack.h          |    2 
 include/net/netfilter/nf_conntrack_core.h     |    6 -
 include/net/netfilter/nf_conntrack_ecache.h   |  169 ++++++++++++++++----
 include/net/netfilter/nf_conntrack_extend.h   |    2 
 include/net/netns/conntrack.h                 |    6 -
 net/netfilter/nf_conntrack_core.c             |   91 ++++++-----
 net/netfilter/nf_conntrack_ecache.c           |  214 +++++++++++++++++--------
 net/netfilter/nf_conntrack_expect.c           |   12 +
 net/netfilter/nf_conntrack_ftp.c              |    4 
 net/netfilter/nf_conntrack_netlink.c          |   83 ++++++----
 net/netfilter/nf_conntrack_pptp.c             |   26 ++-
 net/netfilter/nf_conntrack_proto_dccp.c       |    5 -
 net/netfilter/nf_conntrack_proto_sctp.c       |    2 
 net/netfilter/nf_conntrack_proto_tcp.c        |   12 +
 15 files changed, 435 insertions(+), 268 deletions(-)
Signature · 1 line
Signature