Skip to content

powerpc: i2c-mpc: make I2C bus speed configurable

Wolfgang Grandegger linux-devicetree linux-i2c linuxppc-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 of 8 patches 12 repliesIn review

4 of 8 patches are in this archive. The cover letter announces 8.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
3/8powerpc/85xx: Add support for the "socrates" board (MPC8544).arch/powerpc/boot/dts/socrates.dts arch/powerpc/configs/85xx/socrates_defconfig arch/powerpc/platforms/85xx/Kconfig +4 more+2231 -02 replies
4/8powerpc: i2c-mpc: preserve I2C clockingdrivers/i2c/busses/i2c-mpc.c+16 -80 replies
5/8powerpc: i2c-mpc: make I2C bus speed configurablearch/powerpc/platforms/52xx/mpc52xx_common.c arch/powerpc/sysdev/fsl_soc.c drivers/i2c/busses/i2c-mpc.c +1 more+221 -277 replies
8/8NAND: Add support for NAND on the Socrates boarddrivers/mtd/nand/Kconfig drivers/mtd/nand/Makefile drivers/mtd/nand/socrates_nand.c+331 -00 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchWolfgang Grandegger
3/8
4/8
5/8
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] powerpc: i2c-mpc: make I2C bus speed configurable

Following (most of) Grant's suggestions to my RFC:

http://ozlabs.org/pipermail/linuxppc-dev/2009-March/069820.html

this new patch series now uses:

- the I2c node property "fsl,preserve-clocking" to overtake the clock settings from the boot loader. The first patch provides this feature and can be applied *without* delay. This rest will take more time and discussion, I'm afraid :-(.

- the OF match table to define the I2C clock properties, especially the source clock pre-scaler:

  static const struct of_device_id mpc_i2c_of_match[] = {
	{.compatible = "fsl,mpc5200b-i2c",
	 .data = (void *)FSL_I2C_DEV_CLOCK_5200, },
	{.compatible = "fsl,mpc5200-i2c",
	 .data = (void *)FSL_I2C_DEV_CLOCK_5200, },
	{.compatible = "fsl,mpc8313-i2c",
	 .data = (void *)FSL_I2C_DEV_SEPARATE_DFSRR, },
	{.compatible = "fsl,mpc8543-i2c",
	 .data = (void *)(FSL_I2C_DEV_SEPARATE_DFSRR |
			  FSL_I2C_DEV_CLOCK_DIV2), },
	{.compatible = "fsl,mpc8544-i2c",
	 .data = (void *)(FSL_I2C_DEV_SEPARATE_DFSRR |
			  FSL_I2C_DEV_CLOCK_DIV23), },
	/* Backward compatibility */
	{.compatible = "fsl-i2c", },
	{},

};

The "data" field defines the relevant I2C flags.

- arch-specific tables and functions to get the proper Freqency Divider Register (fdr). I added them to sysdev/fsl_soc.c for the MPC8xxx and to platforms/52xx/mpc52xx_common.c for the MPC52xx. This also solves the problem with arch-specific functions, e.g. for getting the bus frequency.

- dev_dbg() and dev_info() to profit from a more descriptive output.

Hope this solution is OK now?

Thanks,

Wolfgang.