Skip to content

git remote update: New option --prune (-p)

Finn Arne Gangstad git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 1 replyIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2builtin-remote.c: Split out prune_remote as a separate function.builtin-remote.c+31 -250 replies
2/2git remote update: New option --pruneDocumentation/git-remote.txt builtin-remote.c+19 -51 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCHv2 0/2] git remote update: New option --prune (-p)
Quoted 5 lines · Junio C Hamano
Quoted 3 lines · Finn Arne Gangstad
Quoted 2 lines · Junio C Hamano

[...]

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

I gave the patch an only cursory look, so I wouldn't comment on the implementation; two things I would look at in the code would be if it makes two connections to the remote to learn the same information (which would be bad)

How bad?

I'd say only "could be improved later" bad.

Ok. I split the patch into two to make it easier to review. 1/2 just splits out prune_remote() as a separate function, and does not change any behavior.
2/2 adds the new option to remote update.

Finn Arne Gangstad (2):
builtin-remote.c: Split out prune_remote as a separate function. git remote update: New option --prune

 Documentation/git-remote.txt |    4 ++-
 builtin-remote.c             |   76 ++++++++++++++++++++++++++----------------
 2 files changed, 50 insertions(+), 30 deletions(-)

- Finn Arne