Skip to content

ir-kbd-i2c conversion to the new i2c binding model

Jean Delvare linux-media 1 version NAK

Status from this message: Nacked-by: Mike Isely <[email protected]>

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 65 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/6cx18: Fix the handling of i2c bus registration errorlinux/drivers/media/video/cx18/cx18-i2c.c+13 -35 replies
2/6ir-kbd-i2c: Don't use i2c_client.name for our own needslinux/drivers/media/video/cx231xx/cx231xx-input.c linux/drivers/media/video/em28xx/em28xx-cards.c linux/drivers/media/video/em28xx/em28xx-input.c +3 more+15 -130 replies
3/6ir-kbd-i2c: Switch to the new-style device binding modellinux/drivers/media/video/bt8xx/bttv-i2c.c linux/drivers/media/video/cx18/cx18-i2c.c linux/drivers/media/video/cx231xx/cx231xx-cards.c +14 more+284 -19652 replies
4/6ir-kbd-i2c: Use initialization datalinux/drivers/media/video/cx231xx/cx231xx-cards.c linux/drivers/media/video/cx231xx/cx231xx-i2c.c linux/drivers/media/video/cx231xx/cx231xx.h +8 more+76 -1580 replies
5/6saa7134: Simplify handling of IR on MSI TV@nywhere Pluslinux/drivers/media/video/saa7134/saa7134-input.c+7 -200 replies
6/6saa7134: Simplify handling of IR on AVerMedia Cardbuslinux/drivers/media/video/saa7134/saa7134-input.c+5 -300 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchAndy WallsMike Isely
1/6R-b A-b A-b
2/6
3/6Nacked-by
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] ir-kbd-i2c conversion to the new i2c binding model

Hi all,

Here finally comes my conversion of ir-kbd-i2c to the new i2c binding model. I've split it into 6 pieces for easier review. Firstly there are 2 preliminary patches:

media-video-01-cx18-fix-i2c-error-handling.patch media-video-02-ir-kbd-i2c-dont-abuse-client-name.patch

Then 2 patches doing the actual conversion:

media-video-03-ir-kbd-i2c-convert-to-new-style.patch media-video-04-configure-ir-receiver.patch

And lastly 2 patches cleaning up saa7134-input thanks to the new possibilities offered by the conversion:

media-video-05-saa7134-input-cleanup-msi-ir.patch media-video-06-saa7134-input-cleanup-avermedia-cardbus.patch

This patch set is against the v4l-dvb repository, but I didn't pay attention to the compatibility issues. I simply build-tested it on 2.6.27 and 2.6.29.

This patch set touches many different drivers and I can't test any of them. My only TV card with an IR receiver doesn't make use of ir-kbd-i2c. So I would warmly welcome testers. The more testing my changes can get, the better.

And of course I welcome reviews and comments as well. I had to touch many drivers I don't know anything about so it is possible that I missed something.

I'll post all 6 patches as replies to this post. They can also be temporarily downloaded from:
http://jdelvare.pck.nerim.net/linux/ir-kbd-i2c/
Additionally I've put a combined patch there, to make testing easier:
http://jdelvare.pck.nerim.net/linux/ir-kbd-i2c/ir-kbd-i2c-conversion-ALL-IN-ONE.patch
But for review the individual patches are much better.

Thanks,

Signature · 1 line
Jean Delvare