Skip to content

sensord: Some cleanups,

Andre Prendel lm-sensors 1 version In review

Get series with b4
b4 am 20090406075553.GA4734@ubuntu

Versions newest first

  1. v1 Latest8 patches 17 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8sensord: Remove commandline interface.prog/sensord/args.c+9 -283 replies
2/8sensord: Fix help stringprog/sensord/args.c+31 -122 replies
3/8sensord: Introduce struct sensord_argumentsprog/sensord/args.c prog/sensord/args.h prog/sensord/rrd.c +3 more+139 -1200 replies
4/8sensord: Fix switch statementprog/sensord/args.c+0 -41 reply
5/8sensord: Refactoring of parseChips()prog/sensord/args.c+19 -182 replies
6/8sensord: Refactoring of loadConfig()prog/sensord/lib.c+53 -402 replies
7/8sensord: Use sigaction() for signalprog/sensord/sensord.c+25 -73 replies
8/8sensord: Refactoring of rrdInit()prog/sensord/rrd.c+39 -462 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [lm-sensors] [PATCH 0/8] sensord: Some cleanups,

Hello Jean,

this patch series fixes some issues caused by the coding style conversion a while ago. Most of them are deep indentation levels and the related long lines.

Another patch removes the hidden commandline interface. You can call sensord as an console application if you have a link (sensors) pointing to the sensors deamon (sensord). IMO that's really intransparent and I don't know any reason using this.

Further there is a patch introducing a new structure (sensord_arguments). The extern struct sensord_args in args.c now is the place for all the commandline arguments.

A last one replaces the deprecated signal() function by sigaction.

Andre
---

 args.c    |  205 +++++++++++++++++++++++++++++---------------------------------
 args.h    |   30 +++++++++
 lib.c     |   93 ++++++++++++++++------------
 rrd.c     |  108 ++++++++++++++++----------------
 sense.c   |    6 -
 sensord.c |   89 ++++++++++++++++----------
 sensord.h |   18 -----
 7 files changed, 294 insertions(+), 255 deletions(-)

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors