Skip to content

POISON: Intro

Andi Kleen linux-btrfs linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 58 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16POISON: Add support for high priority work itemsinclude/linux/workqueue.h kernel/workqueue.c+18 -00 replies
2/16POISON: Add page flag for poisoned pagesinclude/linux/page-flags.h+15 -17 replies
3/16POISON: Handle poisoned pages in page freemm/page_alloc.c+9 -05 replies
4/16POISON: Export some rmap vma locking to outside worldinclude/linux/rmap.h mm/rmap.c+8 -20 replies
5/16POISON: Add support for poison swap entriesinclude/linux/swap.h include/linux/swapops.h mm/swapfile.c+68 -84 replies
6/16POISON: Add new SIGBUS error codes for poison signalsinclude/asm-generic/siginfo.h+7 -10 replies
7/16POISON: Add basic support for poisoned pages in fault handlerinclude/linux/mm.h mm/memory.c+16 -42 replies
8/16POISON: Add various poison checks in mm/memory.cmm/memory.c+7 -05 replies
9/16POISON: x86: Add VM_FAULT_POISON handling to x86 page fault handlerarch/x86/mm/fault.c+14 -40 replies
10/16POISON: Use bitmask/action code for try_to_unmap behaviourinclude/linux/rmap.h mm/migrate.c mm/rmap.c +1 more+37 -214 replies
11/16POISON: Handle poisoned pages in try_to_unmapmm/rmap.c+8 -10 replies
12/16POISON: Handle poisoned pages in set_page_dirty()mm/page-writeback.c+4 -00 replies
13/16POISON: The high level memory error handler in the VMfs/proc/meminfo.c include/linux/mm.h kernel/sysctl.c +3 more+605 -118 replies
14/16x86: MCE: Rename mce_notify_user to mce_notify_irqarch/x86/include/asm/mce.h arch/x86/kernel/cpu/mcheck/mce-inject.c arch/x86/kernel/cpu/mcheck/mce_64.c +2 more+9 -90 replies
15/16x86: MCE: Support action-optional machine checksarch/x86/Kconfig arch/x86/include/asm/irq_vectors.h arch/x86/include/asm/mce.h +3 more+125 -20 replies
16/16POISON: Add madvise() based injector for poisoned datainclude/asm-generic/mman.h mm/madvise.c+38 -00 replies

Reviews trailers per patch

2 of 16 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRik van RielChristoph LameterHidehiro Kawai
SeriesR-b
1/16
2/16A-b
3/16
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16A-b
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH] [0/16] POISON: Intro

Upcoming Intel CPUs have support for recovering from some memory errors. This requires the OS to declare a page "poisoned", kill the processes associated with it and avoid using it in the future. This patchkit implements the necessary infrastructure in the VM.

To quote the overview comment:

* High level machine check handler. Handles pages reported by the
* hardware as being corrupted usually due to a 2bit ECC memory or cache
* failure.
*
* This focusses on pages detected as corrupted in the background.
* When the current CPU tries to consume corruption the currently
* running process can just be killed directly instead. This implies
* that if the error cannot be handled for some reason it's safe to
* just ignore it because no corruption has been consumed yet. Instead
* when that happens another machine check will happen.
*
* Handles page cache pages in various states. The tricky part
* here is that we can access any page asynchronous to other VM
* users, because memory failures could happen anytime and anywhere,
* possibly violating some of their assumptions. This is why this code
* has to be extremely careful. Generally it tries to use normal locking
* rules, as in get the standard locks, even if that means the
* error handling takes potentially a long time.
*
* Some of the operations here are somewhat inefficient and have non
* linear algorithmic complexity, because the data structures have not
* been optimized for this case. This is in particular the case
* for the mapping from a vma to a process. Since this case is expected
* to be rare we hope we can get away with this.

The code consists of a the high level handler in mm/memory-failure.c, a new page poison bit and various checks in the VM to handle poisoned pages.

The main target right now is KVM guests, but it works for all kinds of applications.

For the KVM use there was need for a new signal type so that KVM can inject the machine check into the guest with the proper address. This in theory allows other applications to handle memory failures too. The expection is that near all applications won't do that, but some very specialized ones might.

This is not fully complete yet, in particular there are still ways to access poison through various ways (crash dump, /proc/kcore etc.) that need to be plugged too.

Also undoubtedly the high level handler still has bugs and cases it cannot recover from. For example nonlinear mappings deadlock right now and a few other cases lose references. Huge pages are not supported yet. Any additional testing, reviewing etc. welcome.

The patch series requires the earlier x86 MCE feature series for the x86 specific action optional part. The code can be tested without the x86 specific part using the injector, this only requires to enable the Kconfig entry manually in some Kconfig file (by default it is implicitely enabled by the architecture)

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>