Skip to content

ACPI: button: minor cleanups

Bjorn Helgaas linux-acpi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ACPI: button: whitespace changesdrivers/acpi/button.c+4 -60 replies
2/6ACPI: button: remove unnecessary null pointer checksdrivers/acpi/button.c+1 -210 replies
3/6ACPI: button: use Linux style for getting driver_datadrivers/acpi/button.c+4 -90 replies
4/6ACPI: button: cache hid/name/class pointersdrivers/acpi/button.c+24 -240 replies
5/6ACPI: button: remove button->device pointerdrivers/acpi/button.c+13 -180 replies
6/6ACPI: button: remove control method/fixed hardware distinctionsdrivers/acpi/button.c+6 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] ACPI: button: minor cleanups

These are minor cleanups - mostly whitespace and style. With the exception of the last, none should make any functional difference.

The last one does make a minor change in /proc "info" files: it removes the "(FF)" or "(CM)" annotation for power and sleep buttons. If anybody thinks that's important, I could rework that patch to keep the annotations while removing the other useless distinctions in the driver.

---

Bjorn Helgaas (6):
ACPI: button: remove control method/fixed hardware distinctions
ACPI: button: remove button->device pointer
ACPI: button: cache hid/name/class pointers
ACPI: button: use Linux style for getting driver_data
ACPI: button: remove unnecessary null pointer checks
ACPI: button: whitespace changes

 drivers/acpi/button.c |  140 +++++++++++++++----------------------------------
 1 files changed, 44 insertions(+), 96 deletions(-)
Signature · 1 line
Bjorn