Skip to content

ir-kbd-i2c conversion to the new i2c binding model (v2)

Jean Delvare linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ir-kbd-i2c: Don't use i2c_client.name for our own needslinux/drivers/media/video/cx231xx/cx231xx-input.c linux/drivers/media/video/em28xx/em28xx-cards.c linux/drivers/media/video/em28xx/em28xx-input.c +3 more+15 -130 replies
2/6ir-kbd-i2c: Switch to the new-style device binding modellinux/drivers/media/video/bt8xx/bttv-i2c.c linux/drivers/media/video/cx231xx/cx231xx-cards.c linux/drivers/media/video/cx231xx/cx231xx-i2c.c +14 more+244 -1949 replies
3/6ir-kbd-i2c: Use initialization datalinux/drivers/media/video/cx231xx/cx231xx-cards.c linux/drivers/media/video/cx231xx/cx231xx-i2c.c linux/drivers/media/video/cx231xx/cx231xx.h +8 more+76 -1470 replies
4/6ir-kbd-i2c: Don't assume all IR receivers are supportedlinux/drivers/media/video/ir-kbd-i2c.c+10 -30 replies
5/6saa7134: Simplify handling of IR on MSI TV@nywhere Pluslinux/drivers/media/video/saa7134/saa7134-input.c+15 -130 replies
6/6saa7134: Simplify handling of IR on AVerMedia Cardbus E506Rlinux/drivers/media/video/saa7134/saa7134-input.c+4 -280 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchOldrich Jedlicka
1/6
2/6
3/6
4/6
5/6
6/6T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] ir-kbd-i2c conversion to the new i2c binding model (v2)

Hi all,

Here comes an update of my conversion of ir-kbd-i2c to the new i2c binding model. I've split it into 6 pieces for easier review. Firstly there is 1 preliminary patch:

01-ir-kbd-i2c-dont-abuse-client-name.patch

Then 3 patches doing the actual conversion:

02-ir-kbd-i2c-convert-to-new-style.patch 03-configure-ir-receiver.patch 04-ir-kbd-i2c-dont-bind-to-unsupported-devices.patch

And lastly 2 patches cleaning up saa7134-input thanks to the new possibilities offered by the conversion:

04-saa7134-input-cleanup-msi-ir.patch
05-saa7134-input-cleanup-avermedia-cardbus.patch

This patch set is against the v4l-dvb repository, but I didn't pay attention to the compatibility issues. I simply build-tested it on 2.6.27 and 2.6.29.

This patch set touches many different drivers and I can't test any of them. My only TV card with an IR receiver doesn't make use of ir-kbd-i2c. So I would warmly welcome testers. The more testing my changes can get, the better.

And of course I welcome reviews and comments as well. I had to touch many drivers I don't know anything about so it is possible that I missed something.

The main difference with my initial patch set is that the ir-kbd-i2c devices are named ir_video instead of ir-kbd. The new name was chosen neutral to make it clear that alternative drivers can bind to these devices if so is the user's desire (lirc comes to mind). Such drivers will need to be updated, but with the legacy binding model going away, that had to happen anyway.

I'll post all 6 patches as replies to this post. They can also be temporarily downloaded from:
http://jdelvare.pck.nerim.net/linux/ir-kbd-i2c/
Additionally I've put a combined patch there, to make testing easier:
http://jdelvare.pck.nerim.net/linux/ir-kbd-i2c/ir-kbd-i2c-conversion-ALL-IN-ONE.patch
But for review the individual patches are much better.

Thanks,

Signature · 1 line
Jean Delvare