Skip to content

move calc_load to softirq

Thomas Gleixner lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3timers: use function instead of macro for calc_loadinclude/linux/sched.h kernel/timer.c+14 -201 reply
2/3timer: move calc_load to softirqkernel/time/timekeeping.c kernel/timer.c+44 -173 replies
3/3tiemrs: cleanup avenrun usersfs/proc/loadavg.c include/linux/sched.h kernel/timer.c+27 -370 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchDimitri Sivanich
1/3A-b
2/3A-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 0/3] move calc_load to softirq

calc_load() calculates the load average, which is a rough estimate at best. Right now calc_load() is called from do_timer() under the xtime lock write locked and with interrupts disabled. Dimitri Sivanich noticed 55us xtime lock hold times on a 64 cpu system. He suggested to split calc_load() out of do_timer() and move it out of the xtime locked section of each caller of do_timer():
http://lkml.org/lkml/2009/4/10/318

The following patch series moves the load average calculation to the timer softirq and removes the xtime lock dependency in the generic code. This reduces also the interrupt off section of the timer interrupt.

Thanks,

tglx