Skip to content

RFC PM/Hibernate: Rework memory shrinking

Rafael J. Wysocki linux-mm linux-pm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 24 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5PM/Freezer: Disable OOM killer when tasks are frozeninclude/linux/freezer.h kernel/power/process.c mm/page_alloc.c+19 -00 replies
1/5PM/Freezer: Disable OOM killer when tasks are frozeninclude/linux/freezer.h kernel/power/process.c mm/page_alloc.c+19 -08 replies
1/5mm: Introduce __GFP_NO_OOM_KILLinclude/linux/gfp.h mm/page_alloc.c+8 -30 replies
1/5mm: Introduce __GFP_NO_OOM_KILLinclude/linux/gfp.h mm/page_alloc.c+8 -32 replies
2/5PM/Suspend: Do not shrink memory before suspendkernel/power/main.c+1 -190 replies
2/5PM/Suspend: Do not shrink memory before suspendkernel/power/main.c+1 -192 replies
2/5PM/Suspend: Do not shrink memory before suspendkernel/power/main.c mm/vmscan.c+3 -210 replies
2/5PM/Suspend: Do not shrink memory before suspendkernel/power/main.c mm/vmscan.c+3 -212 replies
3/5PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2)kernel/power/power.h kernel/power/snapshot.c kernel/power/swsusp.c+79 -810 replies
3/5PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2)kernel/power/power.h kernel/power/snapshot.c kernel/power/swsusp.c+79 -810 replies
3/5PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2)kernel/power/power.h kernel/power/snapshot.c kernel/power/swsusp.c+79 -810 replies
3/5PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2)kernel/power/power.h kernel/power/snapshot.c kernel/power/swsusp.c+79 -812 replies
4/5PM/Hibernate: Rework shrinking of memorykernel/power/snapshot.c+98 -470 replies
4/5PM/Hibernate: Rework shrinking of memorykernel/power/snapshot.c+98 -4710 replies
4/5PM/Hibernate: Rework shrinking of memorykernel/power/snapshot.c+97 -470 replies
4/5PM/Hibernate: Rework shrinking of memorykernel/power/snapshot.c+97 -470 replies
5/5PM/Hibernate: Do not release preallocated memory unnecessarilykernel/power/disk.c kernel/power/power.h kernel/power/snapshot.c+122 -650 replies
5/5PM/Hibernate: Do not release preallocated memory unnecessarilykernel/power/disk.c kernel/power/power.h kernel/power/snapshot.c+122 -650 replies
5/5PM/Hibernate: Do not release preallocated memory unnecessarilykernel/power/disk.c kernel/power/power.h kernel/power/snapshot.c+124 -660 replies
5/5PM/Hibernate: Do not release preallocated memory unnecessarilykernel/power/disk.c kernel/power/power.h kernel/power/snapshot.c+124 -660 replies

Reviews trailers per patch

8 of 20 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPavel MachekNigel CunninghamWu FengguangRafael J. Wysocki
SeriesA-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b Not-yet-signed-off-by Not-yet-signed-off-by
1/5
1/5
1/5
1/5
2/5A-b A-b A-b A-b A-b A-b
2/5A-b A-b A-b A-b A-b A-b
2/5A-b A-b A-b A-b A-b A-b
2/5A-b A-b A-b A-b A-b A-b
3/5A-b A-b A-b A-b A-b A-b
3/5A-b A-b A-b A-b A-b A-b
3/5A-b A-b A-b A-b A-b A-b
3/5A-b A-b A-b A-b A-b A-b
4/5
4/5
4/5
4/5
5/5
5/5
5/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [RFC][PATCH 0/5] PM/Hibernate: Rework memory shrinking

Hi,

The following patchset is an attempt to rework the memory shrinking mechanism used during hibernation to make room for the image. It is a work in progress and most likely it's going to be modified, but it has been discussed recently and I'd like to get comments on the current version.

[1/5] - disable the OOM kernel after freezing tasks (this will be dropped if
it's verified that we can avoid the OOM killing by using __GFP_FS|__GFP_WAIT|__GFP_NORETRY|__GFP_NOWARN
in the next patches).

[2/5] - drop memory shrinking from the suspend (to RAM) code path

[3/5] - move swsusp_shrink_memory() to snapshot.c

[4/5] - rework swsusp_shrink_memory() (to use memory allocations for applying
memory pressure)

[5/5] - allocate image pages along with the shrinking.

Details are in the changelogs, please have a look and tell me what you think.

Best,
Rafael

Signature · 3 lines
Everyone knows that debugging is twice as hard as writing a program
in the first place.  So if you're as clever as you can be when you write it,
how will you ever debug it? --- Brian Kernighan