RFC PM/Hibernate: Rework memory shrinking (rev. 3)
Status from this message: Nack, unnecessary in mmotm and my patch series from
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest6 patches 70 repliesNAK
Patches in v1
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | mm: Introduce __GFP_NO_OOM_KILLinclude/ mm/ | +8 | 0 replies | |
| 1/6 | mm: Introduce __GFP_NO_OOM_KILLinclude/ mm/ | +8 | 8 replies | |
| 1/6 | PM/Suspend: Do not shrink memory before suspendkernel/ mm/ | +3 | 0 replies | |
| 1/6 | PM/Suspend: Do not shrink memory before suspendkernel/ mm/ | +3 | 0 replies | |
| 2/6 | PM/Suspend: Do not shrink memory before suspendkernel/ mm/ | +3 | 0 replies | |
| 2/6 | PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2)kernel/ kernel/ kernel/ | +79 | 0 replies | |
| 2/6 | PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2)kernel/ kernel/ kernel/ | +79 | 0 replies | |
| 3/6 | PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2)kernel/ kernel/ kernel/ | +79 | 0 replies | |
| 3/6 | PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2)kernel/ kernel/ kernel/ | +79 | 0 replies | |
| 3/6 | mm, PM/Freezer: Disable OOM killer when tasks are frozeninclude/ kernel/ mm/ | +22 | 0 replies | |
| 3/6 | mm, PM/Freezer: Disable OOM killer when tasks are frozeninclude/ kernel/ mm/ | +22 | 8 replies | |
| 4/6 | PM/Hibernate: Rework shrinking of memorykernel/ | +165 | 0 replies | |
| 4/6 | PM/Hibernate: Rework shrinking of memorykernel/ | +165 | 0 replies | |
| 4/6 | PM/Hibernate: Rework shrinking of memorykernel/ | +168 | 0 replies | |
| 4/6 | PM/Hibernate: Rework shrinking of memorykernel/ | +168 | 16 replies | |
| 5/6 | PM/Hibernate: Do not release preallocated memory unnecessarilykernel/ kernel/ kernel/ | +130 | 0 replies | |
| 5/6 | PM/Hibernate: Do not release preallocated memory unnecessarilykernel/ kernel/ kernel/ | +130 | 2 replies | |
| 5/6 | PM/Hibernate: Do not release preallocated memory unnecessarily (rev. 2)kernel/ kernel/ kernel/ | +149 | 0 replies | |
| 5/6 | PM/Hibernate: Do not release preallocated memory unnecessarily (rev. 2)kernel/ kernel/ kernel/ | +149 | 8 replies | |
| 6/6 | PM/Hibernate: Estimate hard core working set sizekernel/ | +44 | 0 replies | |
| 6/6 | PM/Hibernate: Estimate hard core working set sizekernel/ | +44 | 2 replies | |
| 6/6 | PM/Hibernate: Do not try to allocate too much memory too hardkernel/ | +52 | 0 replies | |
| 6/6 | PM/Hibernate: Do not try to allocate too much memory too hardkernel/ | +52 | 26 replies |
Reviews trailers per patch
19 of 23 patches have a Reviewed-by or Acked-by.
| Patch | Nigel Cunningham | Wu Fengguang | Pavel Machek | Rafael J. Wysocki |
|---|---|---|---|---|
| 1/6 | A-b A-b | A-b A-b | ||
| 1/6 | A-b A-b | A-b A-b | ||
| 1/6 | A-b A-b | A-b A-b | ||
| 1/6 | A-b A-b | A-b A-b | ||
| 2/6 | A-b | A-b A-b A-b | A-b A-b | |
| 2/6 | A-b | A-b A-b A-b | A-b A-b | |
| 2/6 | A-b | A-b A-b A-b | A-b A-b | |
| 3/6 | A-b A-b | A-b A-b A-b A-b | ||
| 3/6 | A-b A-b | A-b A-b A-b A-b | ||
| 3/6 | A-b A-b | A-b A-b A-b A-b | ||
| 3/6 | A-b A-b | A-b A-b A-b A-b | ||
| 4/6 | A-b A-b | |||
| 4/6 | A-b A-b | |||
| 4/6 | A-b A-b | |||
| 4/6 | A-b A-b | |||
| 5/6 | ||||
| 5/6 | ||||
| 5/6 | ||||
| 5/6 | ||||
| 6/6 | A-b A-b | Not-yet-signed-off-by Not-yet-signed-off-by | ||
| 6/6 | A-b A-b | Not-yet-signed-off-by Not-yet-signed-off-by | ||
| 6/6 | A-b A-b | Not-yet-signed-off-by Not-yet-signed-off-by | ||
| 6/6 | A-b A-b | Not-yet-signed-off-by Not-yet-signed-off-by |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [RFC][PATCH 0/6] PM/Hibernate: Rework memory shrinking (rev. 3)
Quoted 15 lines · Rafael J. Wysocki
Quoted 14 lines · Rafael J. Wysocki
Hi,
The following patchset is an attempt to rework the memory shrinking mechanism used during hibernation to make room for the image. It is a work in progress and most likely it's going to be modified, but it has been discussed recently and I'd like to get comments on the current version.
[1/5] - disable the OOM kernel after freezing tasks (this will be dropped if
it's verified that we can avoid the OOM killing by using __GFP_FS|__GFP_WAIT|__GFP_NORETRY|__GFP_NOWARN
in the next patches).[2/5] - drop memory shrinking from the suspend (to RAM) code path
Quoted 8 lines
Quoted 6 lines
[3/5] - move
swsusp_shrink_memory()tosnapshot.c[4/5] - rework
swsusp_shrink_memory()(to use memory allocations for applying
memory pressure)[5/5] - allocate image pages along with the shrinking.
Updated patchset follows.
I the meantime I added a patch that attempts to computer the size of the hard core working set. I also had to rework the patch reworking swsusp_shrink_memory() so that it takes highmem into account.
Currently, the patchset consists of the following patches:
[1/6] - disable the OOM kernel after freezing tasks (this will be dropped if
it's verified that we can avoid the OOM killing by using __GFP_FS|__GFP_WAIT|__GFP_NORETRY|__GFP_NOWARN
in the next patches).
[2/6] - drop memory shrinking from the suspend (to RAM) code path
[3/6] - move swsusp_shrink_memory() to snapshot.c
[4/6] - rework swsusp_shrink_memory() (to use memory allocations for applying
memory pressure)
[5/6] - allocate image pages along with the shrinking
[6/6] - estimate the size of the hard core working set and use it as the lower
limit of the image size.
Comments welcome.
Thanks,
Rafael