Skip to content

ir-kbd-i2c conversion to the new i2c binding model (v3)

Jean Delvare linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8ir-kbd-i2c: Don't use i2c_client.name for our own needslinux/drivers/media/video/cx231xx/cx231xx-input.c linux/drivers/media/video/em28xx/em28xx-cards.c linux/drivers/media/video/em28xx/em28xx-input.c +3 more+15 -130 replies
2/8ir-kbd-i2c: Switch to the new-style device binding modellinux/drivers/media/video/bt8xx/bttv-i2c.c linux/drivers/media/video/cx231xx/cx231xx-cards.c linux/drivers/media/video/cx231xx/cx231xx-i2c.c +13 more+220 -1940 replies
3/8ir-kbd-i2c: Use initialization datalinux/drivers/media/video/cx231xx/cx231xx-cards.c linux/drivers/media/video/cx231xx/cx231xx-i2c.c linux/drivers/media/video/cx231xx/cx231xx.h +8 more+79 -1500 replies
4/8ir-kbd-i2c: Don't assume all IR receivers are supportedlinux/drivers/media/video/ir-kbd-i2c.c+10 -30 replies
5/8saa7134: Simplify handling of IR on MSI TV@nywhere Pluslinux/drivers/media/video/saa7134/saa7134-input.c+15 -130 replies
6/8saa7134: Simplify handling of IR on AVerMedia Cardbus E506Rlinux/drivers/media/video/saa7134/saa7134-input.c+5 -280 replies
7/8ivtv: Probe more I2C addresses for IR deviceslinux/drivers/media/video/ivtv/ivtv-i2c.c+6 -10 replies
8/8pvrusb2: Instantiate ir_video I2C device by defaultlinux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c+1 -11 reply

Reviews trailers per patch

1 of 8 patches has a Reviewed-by or Acked-by.

PatchOldrich JedlickaMike Isely
1/8
2/8
3/8
4/8
5/8
6/8T-b
7/8
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] ir-kbd-i2c conversion to the new i2c binding model (v3)

Hi all,

Here comes an update of my conversion of ir-kbd-i2c to the new i2c binding model. I've split it into 8 pieces for easier review. Firstly there is 1 preliminary patch:

01-ir-kbd-i2c-dont-abuse-client-name.patch

Then 3 patches doing the actual conversion:

02-ir-kbd-i2c-convert-to-new-style.patch 03-configure-ir-receiver.patch 04-ir-kbd-i2c-dont-bind-to-unsupported-devices.patch

Then 2 patches cleaning up saa7134-input thanks to the new possibilities offered by the conversion:

05-saa7134-input-cleanup-msi-ir.patch
06-saa7134-input-cleanup-avermedia-cardbus.patch

And lastly driver-specific adjustments:
07-ir-add-lirc-addresses.patch
08-pvrusb2-enable-ir_video-by-default.patch

This patch set is against the v4l-dvb repository, but I didn't pay attention to the compatibility issues. I simply build-tested it on 2.6.27, 2.6.29 and 2.6.30-rc5.

This patch set touches many different drivers and I can't test any of them. My only TV card with an IR receiver doesn't make use of ir-kbd-i2c. So I would warmly welcome testers. The more testing my changes can get, the better.

And of course I welcome reviews and comments as well. I had to touch many drivers I don't know anything about so it is possible that I missed something.

The main difference with my previous patch set is that it is adjusted to apply after Mike Isely's recent prvusb2 patches.

I'll post all 8 patches as replies to this post. They can also be temporarily downloaded from:
http://jdelvare.pck.nerim.net/linux/ir-kbd-i2c/
Additionally I've put a combined patch there, to make testing easier:
http://jdelvare.pck.nerim.net/linux/ir-kbd-i2c/ir-kbd-i2c-conversion-ALL-IN-ONE.patch
But for review the individual patches are much better.

Thanks,

Signature · 1 line
Jean Delvare