Skip to content

: Discard reserved PXM bits for SRAT v1

Kurt Garloff linux-acpi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3: Store SRAT revisiondrivers/acpi/numa.c include/acpi/acpi_numa.h+4 -00 replies
1/3Resend: [PATCH 1/3]: Store SRAT revisiondrivers/acpi/numa.c include/acpi/acpi_numa.h+4 -00 replies
2/3Resend: x86-64: Handle SRAT v1 and v2 consistentlyarch/x86/mm/srat_64.c+4 -01 reply
3/3: Consider SRAT rev on ia64arch/ia64/kernel/acpi.c+6 -40 replies
3/3Resend: Consider SRAT rev on ia64arch/ia64/kernel/acpi.c+6 -40 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchYinghai Lu
SeriesA-b
1/3
1/3
2/3A-b
3/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3]: Discard reserved PXM bits for SRAT v1

Hi,

ACPI specification says that the OS must disregard reserved bits. The x86_64 SRAT parser does not discard the upper 24 bits of the proximity_domain (pxm) in the acpi_srat_mem_affinity entries for SRAT v1 tables. (v2 has 32 bits wide fields.)
This can lead to problems with poor BIOS implementations that failed to set resreved bytes to zero. (The ACPI spec is a bit vague here unfortunately.)

This was also inconsistent: On x86-64 (srat_64.c), the _cpu_affinity does only use the low 8 bits of pxm, while the full 32 bits of _mem_affinity are consumed.
In srat_32.c (x86), only 8bits are used (which is OK, a 32bit system with >256 PXMs does not seem reasonable at all).
On ia64, the support of more than 8 bits was consistent between mem and cpu affinity entries, however it dependent on "sn2" platform.

The patch series has the following goals:
* Make the kernel support consistently 8bits or 32bits for the proximity domain
* Make this dependent on the SRAT version; v1 => 8bits, v2 => 32bits.

Overview over the patches:
- [1/3] Store the SRAT table version value in acpi_srat_revision
- [2/3] x86-64: Discard the upper 24 bits in mem_affinity if rev <= 1 and use upper 24bits in cpu_affinity if rev >= 2
- [3/3] ia64: Also use upper 8/24bits if rev >= 2 (but leave logic to enable on sn2 as well -- I don't know if sn2 reports v1 or v2 SRAT) Also add two __init decls in ia64 pxm accessors.

Patch has been tested on x86-64 against an 2.6.27.x kernel. (Patch is against current git.)

Thanks for James, Greg, Alexey, Norbert for comments, review and testing.

Please review and apply!

Greg, I believe this is a candidate for -stable.

Signature · 1 line
Kurt Garloff, VP OPS Partner Engineering -- Novell Inc.