Skip to content

: Get rid of BUS_ID_SIZE in networking

David Miller netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6: net: Remove bogus reference to BUS_ID_SIZE in sysfs code.net/core/net-sysfs.c+0 -10 replies
2/6: ixp4xx_eth: Remove references to BUS_ID_SIZE.drivers/net/arm/ixp4xx_eth.c+2 -20 replies
3/6: cpmac: Remove references to BUS_ID_SIZE, use MII_BUS_ID_SIZE.drivers/net/cpmac.c+1 -10 replies
4/6: sh_eth: Remove references to BUS_ID_SIZE, use MII_BUS_ID_SIZE instead.drivers/net/sh_eth.c+1 -10 replies
5/6: nl80211: Eliminate reference to BUS_ID_SIZE.net/wireless/nl80211.c+1 -13 replies
6/6: phy: Eliminate references to BUS_ID_SIZE.include/linux/phy.h+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6]: Get rid of BUS_ID_SIZE in networking

The generic device layer got rid of it's bus name string length limitations by moving to dynamically allocated strings for names.

But there are things all over the tree that indirectly reference the old BUS_ID_SIZE.

I had this glorious and ambitious patch almost finished that tried to tackle the MII_BUS_ID_SIZE thing by similarly implementing dynamic string lengths there but I gave up. :-) It's a lot of work and I do not have the hardware to test this, and in order to just simply build all the effected drivers I would have to use 3 or 4 different cross compiles. No thanks.

So most of this is in the form of either "get rid of it", "replace with constant '20'", or "use MII_BUS_ID instead".

I'm pretty sure I got everything in the networking in net-next-2.6, so if I missed anything let me know.

(Kay, I'll kill the sparc one in my sparc-next-2.6 tree when I
next get the chance.)