Skip to content

HWPOISON: Intro

Andi Kleen linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 99 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16HWPOISON: Add page flag for poisoned pagesinclude/linux/page-flags.h+16 -19 replies
2/16HWPOISON: Export poison flag in /proc/kpageflagsfs/proc/page.c+4 -01 reply
3/16HWPOISON: Export some rmap vma locking to outside worldinclude/linux/rmap.h mm/rmap.c+8 -20 replies
4/16HWPOISON: Add support for poison swap entries v2include/linux/swap.h include/linux/swapops.h mm/swapfile.c+68 -83 replies
5/16HWPOISON: Add new SIGBUS error codes for hardware poison signalsinclude/asm-generic/siginfo.h+7 -10 replies
6/16HWPOISON: Add basic support for poisoned pages in fault handler v2include/linux/mm.h mm/memory.c+17 -42 replies
7/16HWPOISON: Add various poison checks in mm/memory.cmm/memory.c+3 -00 replies
8/16HWPOISON: x86: Add VM_FAULT_HWPOISON handling to x86 page fault handlerarch/x86/mm/fault.c+14 -40 replies
9/16HWPOISON: Use bitmask/action code for try_to_unmap behaviourinclude/linux/rmap.h mm/migrate.c mm/rmap.c +1 more+37 -215 replies
10/16HWPOISON: Handle hardware poisoned pages in try_to_unmapinclude/linux/rmap.h mm/rmap.c+9 -10 replies
11/16HWPOISON: Handle poisoned pages in set_page_dirty()mm/page-writeback.c+4 -00 replies
12/16HWPOISON: check and isolate corrupted free pagesmm/page_alloc.c+16 -60 replies
13/16HWPOISON: The high level memory error handler in the VM v3Documentation/sysctl/vm.txt arch/x86/mm/fault.c fs/proc/meminfo.c +5 more+730 -479 replies
14/16HWPOISON: FOR TESTING: Enable memory failure code unconditionallymm/Kconfig+2 -00 replies
15/16HWPOISON: Add madvise() based injector for hardware poisoned pages v3include/asm-generic/mman.h mm/madvise.c+38 -00 replies
16/16HWPOISON: Add simple debugfs interface to inject hwpoison on arbitary PFNsmm/Kconfig mm/Makefile mm/hwpoison-inject.c+46 -00 replies

Reviews trailers per patch

3 of 16 patches have a Reviewed-by or Acked-by.

PatchChristoph LameterRik van Riel
1/16A-b
2/16A-b
3/16
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16A-b
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH] [0/16] HWPOISON: Intro

This is the latest version of the hwpoison patch. It has a lot of fixes and improvements and review/testing over the last version.

A lot of thanks to Fengguang Wu for doing a lot of great improvements, like fixing quite a lot of problems and implementing free page handling.

It's also standalone now, not relying on any other patchkits. Standalone it's only usable through the debugging injection interfaces, but architectures can (and do) make use of it.

It's also fairly unintruisive, as you can see.
It doesn't really change any existing code paths
significantly.

I believe this version is now ready for merging.

Any additional review/comments/etc of course welcome.

Andrew, can you please consider it for merging into -mm for the 2.6.31 track?

The patchkit is also available in
git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-mce-2.6.git hwpoison

-Andi

---

Upcoming Intel CPUs have support for recovering from some memory errors (``MCA recovery''). This requires the OS to declare a page "poisoned", kill the processes associated with it and avoid using it in the future.

This patchkit implements the necessary infrastructure in the VM.

To quote the overview comment:

* High level machine check handler. Handles pages reported by the
* hardware as being corrupted usually due to a 2bit ECC memory or cache
* failure.
*
* This focusses on pages detected as corrupted in the background.
* When the current CPU tries to consume corruption the currently
* running process can just be killed directly instead. This implies
* that if the error cannot be handled for some reason it's safe to
* just ignore it because no corruption has been consumed yet. Instead
* when that happens another machine check will happen.
*
* Handles page cache pages in various states. The tricky part
* here is that we can access any page asynchronous to other VM
* users, because memory failures could happen anytime and anywhere,
* possibly violating some of their assumptions. This is why this code
* has to be extremely careful. Generally it tries to use normal locking
* rules, as in get the standard locks, even if that means the
* error handling takes potentially a long time.
*
* Some of the operations here are somewhat inefficient and have non
* linear algorithmic complexity, because the data structures have not
* been optimized for this case. This is in particular the case
* for the mapping from a vma to a process. Since this case is expected
* to be rare we hope we can get away with this.

The code consists of a the high level handler in mm/memory-failure.c, a new page poison bit and various checks in the VM to handle poisoned pages.

The main target right now is KVM guests, but it works for all kinds of applications.

For the KVM use there was need for a new signal type so that KVM can inject the machine check into the guest with the proper address. This in theory allows other applications to handle memory failures too. The expection is that near all applications won't do that, but some very specialized ones might.

This is not fully complete yet, in particular there are still ways to access poison through various ways (crash dump, /proc/kcore etc.) that need to be plugged too.

Also undoubtedly the high level handler still has bugs and cases it cannot recover from. For example nonlinear mappings deadlock right now and a few other cases lose references. Huge pages are not supported yet. Any additional testing, reviewing etc. welcome.

The patch series requires the earlier x86 MCE feature series for the x86 specific action optional part. The code can be tested without the x86 specific part using the injector, this only requires to enable the Kconfig entry manually in some Kconfig file (by default it is implicitely enabled by the architecture)

v2: Lots of smaller changes in the series based on review feedback. Rename Poison to HWPoison after akpm's request.
A new pfn based injector based on feedback.
A lot of improvements mostly from Fengguang Wu
See comments in the individual patches.

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>