make ->sync_fs mandatory
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest11 of 12 patches 4 repliesIn review
11 of 12 patches are in this archive. The cover letter announces 12.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | affs: add ->sync_fsfs/ | +27 | 0 replies | |
| 2/12 | bfs: add ->sync_fsfs/ | +21 | 0 replies | |
| 3/12 | exofs: add ->sync_fsfs/ | +13 | 1 reply | |
| 4/12 | ext2: add ->sync_fsfs/ | +27 | 0 replies | |
| 6/12 | hfs: add ->sync_fsfs/ | +11 | 0 replies | |
| 7/12 | hfsplus: add ->sync_fsfs/ | +11 | 0 replies | |
| 8/12 | sysv: add ->sync_fsfs/ | +13 | 0 replies | |
| 9/12 | ufs: add ->sync_fsfs/ | +22 | 0 replies | |
| 10/12 | jffs2: call jffs2_write_super from jffs2_sync_fsfs/ | +2 | 0 replies | |
| 11/12 | nilfs2: call nilfs2_write_super from nilfs2_sync_fsfs/ | +2 | 0 replies | |
| 12/12 | remove the call to ->write_super in __sync_filesystemfs/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/12] make ->sync_fs mandatory
Currently the superblock methods are a bit confusing. There is the newer ->sync_fs method which is unconditionally called from __sync_filesystem for data integrity writebacks. And there is the older ->write_super which is called from pdflush for the periodic superblock writeback, but also from __sync_filesystem just before calling ->sync_fs. (And still from file_fsync, but that is about to go away).
This series makes sure all filesystems that need superblock writeouts define a ->sync_fs so we can stop calling ->write_super for the data integrity writeback. This means the presence of ->write_super indicates a filesystem does want periodic superblock writeback and can implement these independently from the data integrity writeback. It also means we don't need to bother with possible s_dirt races for the data integrity syncs.
This patch series first adds ->sync_fs methods to all filesystems having ->write_super, often refactoring the code in that are (and also preparing the ->write_super instances for moving MS_RDONLY checking into the caller), then it makes sure the existing ->sync_fs instaces cover the work previously done in ->write_super for the two cases where they differed widely, and lastly removes the call to ->write_super from __sync_filesystem.