Skip to content

DAPM power sequencing changes

Mark Brown alsa-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ASoC: Sort DAPM power sequences while building listssound/soc/soc-dapm.c+71 -380 replies
2/7ASoC: Factor out DAPM sequence executionsound/soc/soc-dapm.c+61 -610 replies
3/7ASoC: Coalesce register writes for DAPM sequencessound/soc/soc-dapm.c+104 -320 replies
4/7ASoC: Sort specialised mixers and muxes togethersound/soc/soc-dapm.c+17 -170 replies
5/7ASoC: Coalesce power updates for DAPM widgets with eventssound/soc/soc-dapm.c+60 -160 replies
6/7ASoC: Coalesce power updates for PGAssound/soc/soc-dapm.c+8 -20 replies
7/7ASoC: Make DAPM power sequence lists local variablesinclude/sound/soc.h sound/soc/soc-dapm.c+8 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] DAPM power sequencing changes

I've implemented what I hope are some improvements to the DAPM power sequence application. Currently when it is implementing power changes DAPM will do one register write per widget. Normally this leads to multiple writes to the same register since power control tends to be clustered in a few registers, slowing things down. This can get noticable on slow or heavily contended buses, especially around resume. The overall effect of these changes is that DAPM will try to minimise the number of register writes it does when implementing power sequences.

As with any substantial change in the power sequencing there is a risk that there may have been some performance regressions on some systems - my biggest concern is that some thing were being helped by the delays introduced by the repeated register writes and may require special handling to fix. My hope is that this won't happen if anything it should fix some problems by ensuring that both left and right channels of stereo paths get powered up together but without wide testing that's hard to guarantee. Any testing that you can do on your systems would be greatly appreciated.

Obviously this is quite an invasive change so I don't intend to submit to ALSA until after the 2.6.31 merge window has closed. The patches can be found here for the time being:

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git dapm

Mark Brown (7):
ASoC: Sort DAPM power sequences while building lists
ASoC: Factor out DAPM sequence execution
ASoC: Coalesce register writes for DAPM sequences
ASoC: Sort specialised mixers and muxes together
ASoC: Coalesce power updates for DAPM widgets with events
ASoC: Coalesce power updates for PGAs
ASoC: Make DAPM power sequence lists local variables

 include/sound/soc.h  |    2 -
 sound/soc/soc-dapm.c |  302 +++++++++++++++++++++++++++++++++++++-------------
 2 files changed, 227 insertions(+), 77 deletions(-)