Skip to content

: More SKB list abstrations, this time frag lists

David Miller netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15: bluetooth: Kill skb_frags_no(), unused.include/net/bluetooth/bluetooth.h+0 -91 reply
2/15: skbuff: Add frag list abstraction interfaces.include/linux/skbuff.h+20 -10 replies
3/15: netdevice.h: Use frag list abstraction interfaces.include/linux/netdevice.h+1 -10 replies
4/15: appletalk: Use frag list abstraction interfaces.net/appletalk/ddp.c+14 -170 replies
5/15: datagram: Use frag list abstraction interfaces.net/core/datagram.c+83 -950 replies
6/15: net/core/dev.c: Use frag list abstraction interfaces.net/core/dev.c+2 -20 replies
7/15: net/core/skbuff.c: Use frag list abstraction interfaces.net/core/skbuff.c+106 -1240 replies
8/15: net/core/user_dma.c: Use frag list abstraction interfaces.net/core/user_dma.c+22 -240 replies
9/15: ipv4: Use frag list abstraction interfaces.net/ipv4/ip_fragment.c net/ipv4/ip_output.c+5 -50 replies
10/15: ipv6: Use frag list abstraction interfaces.net/ipv6/ip6_output.c net/ipv6/reassembly.c+5 -50 replies
11/15: netfilter: Use frag list abstraction interfaces.net/ipv4/netfilter/nf_nat_proto_sctp.c net/ipv6/netfilter/nf_conntrack_reasm.c+5 -42 replies
12/15: phonet: Use frag list abstraction interfaces.net/phonet/pep-gprs.c net/phonet/pep.c+4 -40 replies
13/15: sctp: Use frag list abstraction interfaces.net/sctp/input.c net/sctp/socket.c net/sctp/ulpevent.c+8 -90 replies
14/15: xfrm: Use frag list abstraction interfaces.net/xfrm/xfrm_algo.c+19 -220 replies
15/15: be2net: Remove unnecessary frag list traversing.drivers/net/benet/be_main.c+25 -310 replies

Reviews trailers per patch

1 of 15 patches has a Reviewed-by or Acked-by.

PatchMarcel Holtmann
1/15A-b
2/15
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/15]: More SKB list abstrations, this time frag lists

This adds some interface butter to skbuff.h so that we can (begin) getting rid of explicit references to how frag lists of skbs are managed.

I couldn't kill every such reference just yet. Some things are hard to abstract.

Looking forward I did some work to see what happens if we use a list_head for the frag lists. It doesn't work right unless we clone all frag list SKBs during a pskb_copy() for example.

The single linked list we have no lets us just copy the head skb->next pointer and bump SKB ref counts, so we may keep it that way in the end.

Anyways, most of this is mechanical and will be pushed out to net-next-2.6 in a few moments.