fix file truncations when both suid and write permissions set
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest2 patches 0 repliesNew
- v42 patches 14 repliesSuperseded
- v31 patch 11 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 posting 2/2 | 1 patch | 1 reply | Superseded | |
| v2 posting 1/2 | 1 patch | 0 replies | Superseded | |
| v1 | 1 patch | 7 replies | Superseded |
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | selinux: adjust rules for ATTR_FORCEsecurity/ | +10 | 0 replies | |
| 2/2 | vfs: allow file truncations when both suid and write permissions setfs/ | +6 | 0 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Stephen Smalley |
|---|---|
| 1/2 | A-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [V5 Patch 0/2] fix file truncations when both suid and write permissions set
Andrew, these two patches can replace the -mm patch "vfs-allow-file-truncations-when-both-suid-and-write-permissions-set.patch".
When suid is set and the non-owner user has write permission, any writing into this file should be allowed and suid should be removed after that.
However, current kernel only allows writing without truncations, when we do truncations on that file, we get EPERM. This is a bug.
Steps to reproduce this bug:
% ls -l rootdir/file1
-rwsrwsrwx 1 root root 3 Jun 25 15:42 rootdir/file1 % echo h > rootdir/file1
zsh: operation not permitted: rootdir/file1 % ls -l rootdir/file1
-rwsrwsrwx 1 root root 3 Jun 25 15:42 rootdir/file1 % echo h >> rootdir/file1
% ls -l rootdir/file1
-rwxrwxrwx 1 root root 5 Jun 25 16:34 rootdir/file1
This patch fixes it.
Thanks!