Skip to content

do_coredump: misc cleanups

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2do_coredump: factor out put_cred() callsfs/exec.c+9 -132 replies
2/2do_coredump: move !ispipe code into "else" branchfs/exec.c+29 -281 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] do_coredump: misc cleanups
Quoted 6 lines · Neil Horman
Quoted 4 lines · Oleg Nesterov

Doesn't look good, if core_pattern starts with "|" any user can set RLIMIT_CORE = 0 and then just do

Quoted 7 lines
Quoted 6 lines
	for (;;)
		if (pid = fork())
			kill(pid, SIGQUIT);

to DOS printk/syslog, no?

I don't think SIGQUIT will trigger this, but SIGSEGV will.

SIGQUIT falls into SIG_KERNEL_COREDUMP_MASK too.

Quoted 2 lines

Regardless, if you
do that, I would think you have bigger problems on your system.

OK, agreed.

Neil, I think you are doing useful changes, but can't we cleanup do_coredump() first?

I just can't look at unnecessary "if (ispipe)" checks...

Oleg.