Skip to content

Fix cpufreq locking dependency (resend)

Mathieu Desnoyers kernel-testers lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4remove rwsem lock from CPUFREQ_GOV_STOP call (second call site)drivers/cpufreq/cpufreq.c+12 -10 replies
2/4CPUFREQ: fix (utter) cpufreq_add_dev messdrivers/cpufreq/cpufreq.c+40 -253 replies
3/4cpufreq add gov mutexdrivers/cpufreq/cpufreq.c+35 -34 replies
4/4cpufreq ondemand and conservative remove dbs_mutexdrivers/cpufreq/cpufreq_conservative.c drivers/cpufreq/cpufreq_ondemand.c+25 -830 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchVenkatesh Pallipadi
1/4A-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [patch 2.6.30 0/4] Fix cpufreq locking dependency (resend)

(sorry, quilt mail problems in the previous post, here is the resend)

Hi,

Here is a patchset applying on 2.6.30 which should fix the cpufreq locking dependency. Sadly, my two main test machines does not seem to support cpufreq, so I have only been able to perform very light testing. (I can't afford to lock down my laptop right now).

I went for the most straightforward fix I could think of and kept the current locking structure. As you will see, the second patch cleans up the error handling paths of cpufreq add dev, which were a total mess.

As a general recommendation, creating scripts which does, concurrently :

cpu hotplug up/down
cpufreq sysfs actions
change between cpufreq governors
add governors on random CPU numbers

will likely help stress-testing cpufreq locking. I really did not like what I've seen there. It looked _very_ fragile.

Hopefully this will be better with this patches, but again, testing is welcome.

Thanks,

Mathieu

Signature · 2 lines
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68