Skip to content

: Fixes for ubifs build on ARM

Simon Kagstrom u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8: Move __set/clear_bit from ubifs.h to bitops.hfs/ubifs/ubifs.h include/asm-avr32/bitops.h include/asm-m68k/bitops.h +6 more+52 -322 replies
2/8: Define ffs/fls for all architecturesinclude/asm-arm/bitops.h include/asm-avr32/bitops.h include/asm-i386/bitops.h +8 more+63 -21 reply
3/8: Define test_and_set/clear_bit for ARMinclude/asm-arm/bitops.h+2 -22 replies
3/8: Define test_and_set/clear_bit for ARM+0 -00 replies
4/8: Add unaligned.h for arminclude/asm-arm/unaligned.h+18 -02 replies
5/8: Use do_div from div64.h for vsprintflib_generic/vsprintf.c+1 -66 replies
6/8: Use lldiv to avoid references to __udvidi3 on (at least) ARMdrivers/mtd/ubi/build.c+1 -11 reply
6/8: Use lldiv to avoid references to __udvidi3 on (at least) ARM+0 -00 replies
7/8: Handle VID header offset in ubi part commandcommon/cmd_ubi.c+12 -51 reply
7/8: Handle VID header offset in ubi part commandcommon/cmd_ubi.c+16 -51 reply
8/8: Command improvements for ubifscommon/cmd_ubifs.c+21 -52 replies

Reviews trailers per patch

6 of 11 patches have a Reviewed-by or Acked-by.

PatchStefan Roese
1/8A-b
2/8
3/8
3/8
4/8A-b
5/8A-b
6/8
6/8
7/8A-b A-b
7/8A-b A-b
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/8]: Fixes for ubifs build on ARM

Hello!

This series of patches corrects some of the issues I've had with building and using the ubifs support on ARM (and some general things). In summary:

- move __set_bit and __clear_bit to bitops.h (was defined in ubifs.h)
- define fls for all architectures (and ffs where it was missing)
- unaligned.h was missing for ARM, add it
- use do_div from div64.h for vsprintf (avoid __udivdi3)
- use lldiv in ubifs (again to avoid __udivdi3 references)
- handle VID header offset in the ubi part command
- proper argument checking in ubifsmount

I've built and tested it on ARM (OpenRD base), but some of the patches also affect other architectures, so please look this through!

// Simon