Skip to content

RFC Memory controller soft limit patches (v9)

Balbir Singh linux-mm lkml 1 version In review

Get series with b4
b4 am 20090710125950.5610.99139.sendpatchset@balbir-laptop

Versions newest first

  1. v1 RFC Latest5 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Memory controller soft limit documentation (v9)Documentation/cgroups/memory.txt+36 -10 replies
2/5Memory controller soft limit interface (v9)include/linux/res_counter.h kernel/res_counter.c mm/memcontrol.c+81 -00 replies
3/5Memory controller soft limit organize cgroups (v9)include/linux/res_counter.h kernel/res_counter.c mm/memcontrol.c+279 -470 replies
4/5Memory controller soft limit refactor reclaim flags (v9)mm/memcontrol.c+19 -60 replies
5/5Memory controller soft limit reclaim on contention (v9)include/linux/memcontrol.h include/linux/swap.h mm/memcontrol.c +1 more+259 -152 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchKOSAKI Motohiro
1/5
2/5
3/5
4/5
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC][PATCH 0/5] Memory controller soft limit patches (v9)

From: Balbir Singh <[email protected]>

New Feature: Soft limits for memory resource controller.

Here is v9 of the new soft limit implementation. Soft limits is a new feature for the memory resource controller, something similar has existed in the group scheduler in the form of shares. The CPU controllers interpretation of shares is very different though.

Soft limits are the most useful feature to have for environments where the administrator wants to overcommit the system, such that only on memory contention do the limits become active. The current soft limits implementation provides a soft_limit_in_bytes interface for the memory controller and not for memory+swap controller. The implementation maintains an RB-Tree of groups that exceed their soft limit and starts reclaiming from the group that exceeds this limit by the maximum amount.

v9 attempts to address several review comments for v8 by Kamezawa, including moving over to an event based approach for soft limit rb tree management, simplification of data structure names and many others. Comments not addressed have been answered via email or I've added comments in the code.

TODOs

1. The current implementation maintains the delta from the soft limit and pushes back groups to their soft limits, a ratio of delta/soft_limit might be more useful

Tests
-----

I've run two memory intensive workloads with differing soft limits and seen that they are pushed back to their soft limit on contention. Their usage was their soft limit plus additional memory that they were able to grab on the system. Soft limit can take a while before we see the expected results.

I ran overhead tests (reaim) and found no significant overhead as a result of these patches.

Please review, comment.

Series
------

memcg-soft-limits-documentation.patch
memcg-soft-limits-interface.patch
memcg-soft-limits-organize.patch
memcg-soft-limits-refactor-reclaim-bits
memcg-soft-limits-reclaim-on-contention.patch

Signature · 7 lines
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>