Skip to content

arm nomadik: gpio and i2c

Alessandro Rubini u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/2] arm nomadik: gpio and i2c
Quoted 2 lines

Agreed. So we need an gpio_core.c / .h which defines the following functions (just a proposal):

Yes.

Quoted 7 lines
typedef struct gpio_adapter {
	int	(*init_pin)(int pin);
	int	(*set)(int pin, value);
	int	(*get)(int pin);
	int	(*dir)(int pin, int direction);	
	int	(*level)(int pin, int level);
}

I don't understand the init_pin function, nor what "level" is. Actually, even "dir" can be dropped: a get configures as input, a set configures as output, the extra instruction is very little overhead.

But an alternate function configuration is definitely needed: everybody has alternate functions associated to the pins. Just say "0" is gpio and 1...n is SoC-specific.

So, are you going to write it? Or should someone else do that?

thanks
/alessandro