Skip to content

RFC clocksource cleanup / improvement

Martin Schwidefsky lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 17 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5move clock source related code to clocksource.cinclude/linux/clocksource.h kernel/time/clocksource.c kernel/time/timekeeping.c+211 -19311 replies
2/5cleanup clocksource selectionkernel/time/clocksource.c+70 -531 reply
3/5remove clocksource inline functionskernel/time/clocksource.c kernel/time/timekeeping.c+18 -133 replies
4/5clocksource_read/clocksource_read_raw inline functionsinclude/linux/clocksource.h kernel/time/timekeeping.c+49 -422 replies
5/5update clocksource with stop_machineinclude/linux/clocksource.h kernel/time/clocksource.c kernel/time/timekeeping.c+31 -550 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC][patch 0/5] clocksource cleanup / improvement

Greetings,
I had a go at the clocksource code and tried to make it better. The first 4 patches contain some code cleanup and improve the separation between timekeeping.c and clocksource.[ch].
Patch #5 is the one with the real change: the switch to a new clock source is now done with stop_machine instead of checking with every wall time update. A clocksource change is an extremely rare thing, to use stop_machine seems reasonable to me.

What I'd like to do is to make the content of struct clocksource private to clocksource.c and clocksource.h. The biggest road-block to get there is update_wall_time. I stared at it for hours and then gave up. A bit of unfinished business ..

The clocksource patches have been created against todays upstream tree plus the patches from the tip tree, if anyone wants to try them you need to pull from:

    git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-tip
Signature · 4 lines
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.