Skip to content

cciss rmmod/scan-thread fixes

Andrew Patterson linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4cciss: remove logical drive sysfs entries during driver cleanup.drivers/block/cciss.c+4 -10 replies
2/4cciss: use mutex instead of flag to indicate busy initializingdrivers/block/cciss.c drivers/block/cciss.h+6 -51 reply
3/4cciss: use only one scan threaddrivers/block/cciss.c drivers/block/cciss.h+142 -210 replies
4/4cciss: kick off logical drive topology rescan through sysfsDocumentation/ABI/testing/sysfs-bus-pci-devices-cciss drivers/block/cciss.c+40 -30 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMike Miller
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 2 0/4] cciss rmmod/scan-thread fixes

The following series fixes several problems causing hangs while rmmoding the cciss driver. In the process of fixing these hangs, I also reworked the the logical drive scanning kernel thread to use one thread per driver rather than one thread per controller. I also added a sysfs attribute to kick off a controller scan.

Changelog

v2

Staticially initialize scan_mutex and scan_q.
Remove unneeded function declarations.
Added a patch that uses a mutex to indicate we are busy initializing rather than a integer flag.
Remove a possible scan race by moving the busy_initializing unlock after the call to rebuild_luntable in cciss_init_one.
Reworked the scan thread to use a more traditional loop with a set_current_state(TASK_INTERRUPTIBLE); schedule() at the top of the loop.

 .../ABI/testing/sysfs-bus-pci-devices-cciss        |    7 +
 drivers/block/cciss.c                              |  204 +++++++++++++++++---
 drivers/block/cciss.h                              |    9 +
 3 files changed, 191 insertions(+), 29 deletions(-)

Andrew Patterson (4):
cciss: remove logical drive sysfs entries during driver cleanup.
cciss: use mutex instead of flag to indicate busy initializing
cciss: use only one scan thread
cciss: kick off logical drive topology rescan through sysfs

Signature · 1 line
Andrew Patterson