Skip to content

RFC RCU cleanups and simplified preemptable RCU

Paul E. McKenney lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Move private definitions from include/linux/rcutree.h to kernel/rcutree.hinclude/linux/rcutree.h kernel/rcutree.c kernel/rcutree.h +1 more+241 -2110 replies
2/4Renamings to increase RCU clarityDocumentation/RCU/trace.txt include/linux/rcupdate.h include/linux/rcupreempt.h +7 more+94 -621 reply
3/4Consolidate sparse and lockdep declarations in include/linux/rcupdate.hinclude/linux/rcupdate.h include/linux/rcupreempt.h include/linux/rcutree.h+44 -240 replies
4/4Merge preemptable-RCU functionality into hierarchical RCUinclude/linux/init_task.h include/linux/rcupdate.h include/linux/rcupreempt.h +9 more+566 -432 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC -tip 0/4] RCU cleanups and simplified preemptable RCU

[Not for inclusion.]

This patchset contains some RCU cleanups as follows:

o Move private definitions from include/linux/rcutree.h to
kernel/rcutree.h

o Rename variables and functions so that RCU-sched is an
underlying definition, along with RCU-bh and (when so configured) RCU-preempt. RCU then maps to either RCU-sched or RCU-preempt, depending on configuration.

o Consolidate sparse and lockdep into include/linux/rcupdate.h
so that all RCU implementations are set up properly.

With these in place, we add configurable preemptable-RCU functionality to kernel/rcutree.c. This new implementation has much faster and simpler read-side primitives (roughly that of Classic RCU built with CONFIG_PREEMPT), and has update-side performance equal to Classic RCU (at least in absence of blocking/preemption of read-side critical sections). This new implementation should eventually replace the old preemptable RCU, which would remove 2099 lines of code from the kernel.

This patchset is undoubtably buggy, and does not have RCU priority boosting, though it does have the necessary tracking of tasks blocked in RCU read-side critical sections.

 Documentation/RCU/trace.txt   |   14 
 b/Documentation/RCU/trace.txt |    7 
 b/include/linux/init_task.h   |   15 
 b/include/linux/rcupdate.h    |   21 -
 b/include/linux/rcupreempt.h  |    4 
 b/include/linux/rcutree.h     |  211 ------------
 b/include/linux/sched.h       |   13 
 b/init/Kconfig                |   22 -
 b/kernel/Makefile             |    1 
 b/kernel/exit.c               |    1 
 b/kernel/fork.c               |    6 
 b/kernel/rcupreempt.c         |    8 
 b/kernel/rcutree.c            |    2 
 b/kernel/rcutree.h            |  238 +++++++++++++
 b/kernel/rcutree_plugin.h     |  414 +++++++++++++++++++++++
 b/kernel/rcutree_trace.c      |    1 
 b/kernel/sched.c              |    2 
 b/kernel/softirq.c            |    4 
 include/linux/rcupdate.h      |  136 ++++++-
 include/linux/rcupreempt.h    |   20 -
 include/linux/rcutree.h       |  707 +---------------------------------------
 kernel/rcupreempt.c           |   16 
 kernel/rcutree.c              |  317 ++++++++++++------
 kernel/rcutree.h              |  730 +++++++++++++++++++++++++++++++++++++++++-
 kernel/rcutree_trace.c        |   63 +--
 kernel/sched.c                |    4 
 kernel/softirq.c              |    8 
 27 files changed, 1882 insertions(+), 1103 deletions(-)